URL encodes member user names when passing information for public access setting such that those with user names as emails containing a plus will be included in the rule. (#18142)

AndyButland · web-flow · commit 7bcbc748d49e · 2025-02-11T13:36:19.000+01:00
diff --git a/src/Umbraco.Web.UI.Client/src/common/resources/publicaccess.resource.js b/src/Umbraco.Web.UI.Client/src/common/resources/publicaccess.resource.js
@@ -79,7 +79,7 @@ function publicAccessResource($http, umbRequestHelper) {
                 publicAccess.groups = groups;
             }
             else if (Utilities.isArray(usernames) && usernames.length) {
-                publicAccess.usernames = usernames;
+                publicAccess.usernames = usernames.map(u => encodeURIComponent(u));
             }
             else {
                 throw "must supply either userName/password or roles";

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ function publicAccessResource($http, umbRequestHelper) {`
`79`	`79`	`publicAccess.groups = groups;`
`80`	`80`	`}`
`81`	`81`	`else if (Utilities.isArray(usernames) && usernames.length) {`
`82`		`- publicAccess.usernames = usernames;`
	`82`	`+ publicAccess.usernames = usernames.map(u => encodeURIComponent(u));`
`83`	`83`	`}`
`84`	`84`	`else {`
`85`	`85`	`throw "must supply either userName/password or roles";`