Skip to content

Commit 7f88013

Browse files
authored
Make internal & private classes sealed where possible, to avoid code for virtual dispatch (#19719)
1 parent 0bcc26a commit 7f88013

File tree

317 files changed

+451
-479
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

317 files changed

+451
-479
lines changed

src/Umbraco.Cms.Api.Common/Configuration/ConfigureOpenIddict.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace Umbraco.Cms.Api.Common.Configuration;
66

7-
internal class ConfigureOpenIddict : IConfigureOptions<OpenIddictServerAspNetCoreOptions>
7+
internal sealed class ConfigureOpenIddict : IConfigureOptions<OpenIddictServerAspNetCoreOptions>
88
{
99
private readonly IOptions<GlobalSettings> _globalSettings;
1010

src/Umbraco.Cms.Api.Common/Json/NamedSystemTextJsonInputFormatter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace Umbraco.Cms.Api.Common.Json;
66

7-
internal class NamedSystemTextJsonInputFormatter : SystemTextJsonInputFormatter
7+
internal sealed class NamedSystemTextJsonInputFormatter : SystemTextJsonInputFormatter
88
{
99
private readonly string _jsonOptionsName;
1010

src/Umbraco.Cms.Api.Common/Json/NamedSystemTextJsonOutputFormatter.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33

44
namespace Umbraco.Cms.Api.Common.Json;
55

6-
7-
internal class NamedSystemTextJsonOutputFormatter : SystemTextJsonOutputFormatter
6+
internal sealed class NamedSystemTextJsonOutputFormatter : SystemTextJsonOutputFormatter
87
{
98
private readonly string _jsonOptionsName;
109

src/Umbraco.Cms.Api.Delivery/Configuration/ConfigureUmbracoMemberAuthenticationDeliveryApiSwaggerGenOptions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public void Configure(SwaggerGenOptions options)
2626
options.OperationFilter<DeliveryApiSecurityFilter>();
2727
}
2828

29-
private class DeliveryApiSecurityFilter : SwaggerFilterBase<ContentApiControllerBase>, IOperationFilter, IDocumentFilter
29+
private sealed class DeliveryApiSecurityFilter : SwaggerFilterBase<ContentApiControllerBase>, IOperationFilter, IDocumentFilter
3030
{
3131
public void Apply(OpenApiOperation operation, OperationFilterContext context)
3232
{

src/Umbraco.Cms.Api.Delivery/Filters/ContextualizeFromAcceptHeadersAttribute.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public ContextualizeFromAcceptHeadersAttribute()
1313
{
1414
}
1515

16-
private class LocalizeFromAcceptLanguageHeaderAttributeFilter : IActionFilter
16+
private sealed class LocalizeFromAcceptLanguageHeaderAttributeFilter : IActionFilter
1717
{
1818
private readonly IRequestCultureService _requestCultureService;
1919
private readonly IRequestSegmmentService _requestSegmentService;

src/Umbraco.Cms.Api.Delivery/Filters/DeliveryApiAccessAttribute.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public DeliveryApiAccessAttribute()
1111
{
1212
}
1313

14-
private class DeliveryApiAccessFilter : IActionFilter
14+
private sealed class DeliveryApiAccessFilter : IActionFilter
1515
{
1616
private readonly IApiAccessService _apiAccessService;
1717
private readonly IRequestPreviewService _requestPreviewService;

src/Umbraco.Cms.Api.Delivery/Filters/DeliveryApiMediaAccessAttribute.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public DeliveryApiMediaAccessAttribute()
1111
{
1212
}
1313

14-
private class DeliveryApiMediaAccessFilter : IActionFilter
14+
private sealed class DeliveryApiMediaAccessFilter : IActionFilter
1515
{
1616
private readonly IApiAccessService _apiAccessService;
1717

src/Umbraco.Cms.Api.Delivery/Filters/ValidateStartItemAttribute.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public ValidateStartItemAttribute()
1212
{
1313
}
1414

15-
private class ValidateStartItemFilter : IActionFilter
15+
private sealed class ValidateStartItemFilter : IActionFilter
1616
{
1717
private readonly IRequestStartItemProviderAccessor _requestStartItemProviderAccessor;
1818

src/Umbraco.Cms.Api.Delivery/Rendering/RequestContextOutputExpansionStrategyV2.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ private void InitializeExpandAndInclude(IHttpContextAccessor httpContextAccessor
124124
private object? GetPropertyValue(IPublishedProperty property)
125125
=> _propertyRenderer.GetPropertyValue(property, _expandProperties.Peek() is not null);
126126

127-
private class Node
127+
private sealed class Node
128128
{
129129
public string Key { get; private set; } = string.Empty;
130130

src/Umbraco.Cms.Api.Management/DependencyInjection/BackOfficeAuthBuilderExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ private static IUmbracoBuilder AddBackOfficeLogin(this IUmbracoBuilder builder)
7979
}
8080
}
8181

82-
internal class BackofficePipelineFilter : UmbracoPipelineFilter
82+
internal sealed class BackofficePipelineFilter : UmbracoPipelineFilter
8383
{
8484
public BackofficePipelineFilter(string name)
8585
: base(name)

0 commit comments

Comments
 (0)