Skip to content

Commit 84d0ae3

Browse files
V15 QA Fixing the failing media acceptance tests (#18881)
* Fixed the function name due to test helper changes * Updated assertion steps due to UI changes * Added more waits * Bumped version * Increase timeout * Reverted --------- Co-authored-by: Andreas Zerbst <[email protected]>
1 parent aa76f78 commit 84d0ae3

File tree

6 files changed

+9
-8
lines changed

6 files changed

+9
-8
lines changed

tests/Umbraco.Tests.AcceptanceTest/package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/Umbraco.Tests.AcceptanceTest/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
},
2222
"dependencies": {
2323
"@umbraco/json-models-builders": "^2.0.31",
24-
"@umbraco/playwright-testhelpers": "^15.0.41",
24+
"@umbraco/playwright-testhelpers": "^15.0.42",
2525
"camelize": "^1.0.0",
2626
"dotenv": "^16.3.1",
2727
"node-fetch": "^2.6.7"

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithApprovedColor.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ test('can create content with the custom approved color data type', async ({umbr
6363
const customDataTypeName = 'CustomApprovedColor';
6464
const colorValue = 'd73737';
6565
const colorLabel = 'Test Label';
66-
const customDataTypeId = await umbracoApi.dataType.createDefaultApprovedColorDataTypeWithOneItem(customDataTypeName, colorLabel, colorValue);
66+
const customDataTypeId = await umbracoApi.dataType.createApprovedColorDataTypeWithOneItem(customDataTypeName, colorLabel, colorValue);
6767
const documentTypeId = await umbracoApi.documentType.createDocumentTypeWithPropertyEditor(documentTypeName, customDataTypeName, customDataTypeId);
6868
await umbracoApi.document.createDefaultDocument(contentName, documentTypeId);
6969
await umbracoUi.content.goToSection(ConstantHelper.sections.content);

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadVectorGraphics.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ test(`can upload a file with the svg extension in the content`, async ({umbracoA
8080
const contentData = await umbracoApi.document.getByName(contentName);
8181
expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName));
8282
expect(contentData.values[0].value.src).toContain(AliasHelper.toAlias(vectorGraphicsName));
83-
await umbracoUi.content.doesUploadedSvgThumbnailHaveSrc(contentData.values[0].value.src);
83+
await umbracoUi.content.doesUploadedSvgThumbnailHaveSrc(umbracoApi.baseUrl + contentData.values[0].value.src);
8484
});
8585

8686
test('can remove an svg file in the content', async ({umbracoApi, umbracoUi}) => {

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/RenderingContent/RenderingContentWithApprovedColor.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const colorValue = {label: "Test Label", value: "038c33"};
99
let dataTypeId = null;
1010

1111
test.beforeEach(async ({umbracoApi}) => {
12-
dataTypeId = await umbracoApi.dataType.createDefaultApprovedColorDataTypeWithOneItem(customDataTypeName, colorValue.label, colorValue.value);
12+
dataTypeId = await umbracoApi.dataType.createApprovedColorDataTypeWithOneItem(customDataTypeName, colorValue.label, colorValue.value);
1313
});
1414

1515
test.afterEach(async ({umbracoApi}) => {

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeFolder.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ test('can rename a media type folder', async ({umbracoApi, umbracoUi}) => {
5454
await umbracoUi.mediaType.clickRootFolderCaretButton();
5555
await umbracoUi.mediaType.clickActionsMenuForName(oldFolderName);
5656
await umbracoUi.mediaType.clickRenameFolderButton();
57+
await umbracoUi.waitForTimeout(500);
5758
await umbracoUi.mediaType.enterFolderName(mediaTypeFolderName);
5859
await umbracoUi.mediaType.clickConfirmRenameButton();
5960

0 commit comments

Comments
 (0)