Rename CharacterReplacement back to CharItem

Since the class is public renaming this would be a breaking change, since if anyone is directly referring to the class it would break

Author: nikolajlauridsen

src/Umbraco.Core/Configuration/UmbracoSettings/CharacterReplacement.cs renamed to src/Umbraco.Core/Configuration/Models/CharItem.cs

@@ -1,6 +1,6 @@
-namespace Umbraco.Cms.Core.Configuration.UmbracoSettings
+namespace Umbraco.Cms.Core.Configuration.Models
 {
-    public class CharacterReplacement
+    public class CharItem
     {
         /// <summary>
         /// The character to replace

src/Umbraco.Core/Configuration/Models/RequestHandlerSettings.cs

@@ -19,7 +19,7 @@ public class RequestHandlerSettings
         internal const string StaticConvertUrlsToAscii = "try";
         internal const bool StaticEnableDefaultCharReplacements = true;
 
-        internal static readonly CharacterReplacement[] DefaultCharCollection =
+        internal static readonly CharItem[] DefaultCharCollection =
         {
             new () { Char = " ", Replacement = "-" },
             new () { Char = "\"", Replacement = string.Empty },
@@ -78,13 +78,13 @@ public class RequestHandlerSettings
         /// <summary>
         /// Add additional character replacements, or override defaults
         /// </summary>
-        public CharacterReplacement[] CharCollection { get; set; }
+        public CharItem[] CharCollection { get; set; }
 
         /// <summary>
         /// Get concatenated user and default character replacements
         /// taking into account <see cref="EnableDefaultCharReplacements"/>
         /// </summary>
-        public IEnumerable<CharacterReplacement> GetCharReplacements()
+        public IEnumerable<CharItem> GetCharReplacements()
         {
             // TODO We need to special handle ":", as this character is special in keys
 

src/Umbraco.Core/Configuration/UmbracoSettings/CharacterReplacementEqualityComparer.cs

@@ -1,10 +1,11 @@
 using System.Collections.Generic;
+using Umbraco.Cms.Core.Configuration.Models;
 
 namespace Umbraco.Cms.Core.Configuration.UmbracoSettings
 {
-    public class CharacterReplacementEqualityComparer : IEqualityComparer<CharacterReplacement>
+    public class CharacterReplacementEqualityComparer : IEqualityComparer<CharItem>
     {
-        public bool Equals(CharacterReplacement x, CharacterReplacement y)
+        public bool Equals(CharItem x, CharItem y)
         {
             if (ReferenceEquals(x, y))
             {
@@ -29,7 +30,7 @@ public bool Equals(CharacterReplacement x, CharacterReplacement y)
             return x.Char == y.Char && x.Replacement == y.Replacement;
         }
 
-        public int GetHashCode(CharacterReplacement obj)
+        public int GetHashCode(CharItem obj)
         {
             unchecked
             {

tests/Umbraco.Tests.UnitTests/Umbraco.Core/ShortStringHelper/DefaultShortStringHelperTestsWithoutSetup.cs

@@ -20,7 +20,7 @@ public void U4_4056()
         {
             var requestHandlerSettings = new RequestHandlerSettings()
             {
-                CharCollection = Array.Empty<CharacterReplacement>(),
+                CharCollection = Array.Empty<CharItem>(),
                 EnableDefaultCharReplacements = false,
                 ConvertUrlsToAscii = "false"
             };
@@ -47,7 +47,7 @@ public void U4_4056_TryAscii()
         {
             var requestHandlerSettings = new RequestHandlerSettings()
             {
-                CharCollection = Array.Empty<CharacterReplacement>(),
+                CharCollection = Array.Empty<CharItem>(),
                 EnableDefaultCharReplacements = false,
                 ConvertUrlsToAscii = "false"
             };
@@ -342,7 +342,7 @@ public void CleanStringDefaultConfig()
         {
             var requestHandlerSettings = new RequestHandlerSettings()
             {
-                CharCollection = Array.Empty<CharacterReplacement>(),
+                CharCollection = Array.Empty<CharItem>(),
                 EnableDefaultCharReplacements = false,
                 ConvertUrlsToAscii = "false"
             };