Adding a fixed prefix to all future signs, and removing the provider property

Author: NillasKA

src/Umbraco.Cms.Api.Management/Services/Signs/HasScheduleSignProvider.cs

@@ -10,7 +10,7 @@ namespace Umbraco.Cms.Api.Management.Services.Signs;
 /// </summary>
 internal class HasScheduleSignProvider : ISignProvider
 {
-    private const string Alias = "ScheduledForPublish";
+    private const string Alias = ISignProvider.Prefix + "ScheduledForPublish";
 
     private readonly IContentService _contentService;
 
@@ -29,7 +29,7 @@ public Task PopulateTreeSignsAsync<TItem>(TItem[] treeItemViewModels, IEnumerabl
         IEnumerable<Guid> contentKeysScheduledForPublishing = _contentService.GetScheduledContentKeys(treeItemViewModels.Select(x => x.Id));
         foreach (Guid key in contentKeysScheduledForPublishing)
         {
-            treeItemViewModels.First(x => x.Id == key).AddSign(Core.Constants.System.UmbracoSignProvider, Alias);
+            treeItemViewModels.First(x => x.Id == key).AddSign(Alias);
         }
 
         return Task.CompletedTask;

src/Umbraco.Cms.Api.Management/Services/Signs/ISignProvider.cs

@@ -8,6 +8,11 @@ namespace Umbraco.Cms.Api.Management.Services.Signs;
 /// </summary>
 public interface ISignProvider
 {
+    /// <summary>
+    /// Prefix of each sign alias.
+    /// </summary>
+    const string Prefix = "Umb.";
+
     /// <summary>
     /// Gets a value indicating whether this provider can provide tree signs for the specified item type.
     /// </summary>

src/Umbraco.Cms.Api.Management/ViewModels/SignModel.cs

@@ -2,7 +2,5 @@ namespace Umbraco.Cms.Api.Management.ViewModels;
 
 public class SignModel
 {
-    public required string Provider { get; set; }
-
     public required string Alias { get; set; }
 }

src/Umbraco.Cms.Api.Management/ViewModels/Tree/EntityTreeItemResponseModel.cs

@@ -10,7 +10,7 @@ public class EntityTreeItemResponseModel : TreeItemPresentationModel
 
     public IEnumerable<SignModel> Signs => _signs.AsEnumerable();
 
-    public void AddSign(string provider, string alias) => _signs.Add(new SignModel { Provider = provider, Alias = alias });
+    public void AddSign(string alias) => _signs.Add(new SignModel { Alias = alias });
 
-    public void RemoveSign(string provider, string alias) => _signs.RemoveAll(x => x.Provider == provider && x.Alias == alias);
+    public void RemoveSign(string alias) => _signs.RemoveAll(x => x.Alias == alias);
 }