Don't hold static UmbracoContext reference

mattbrailsford · web-flow · commit 8c780573f456 · 2022-02-08T09:41:35.000Z
Fixes #11951 by changing `UmbracoContext` to be an expression rather than being a static setter thus ensuring the current umbraco context is always returned, rather than a cached version from initial execution
diff --git a/src/Umbraco.Web.Common/Extensions/FriendlyUrlHelperExtensions.cs b/src/Umbraco.Web.Common/Extensions/FriendlyUrlHelperExtensions.cs
@@ -9,7 +9,7 @@ namespace Umbraco.Extensions
     public static class FriendlyUrlHelperExtensions
     {
 
-        private static IUmbracoContext UmbracoContext { get; } =
+        private static IUmbracoContext UmbracoContext =>
             StaticServiceProvider.Instance.GetRequiredService<IUmbracoContextAccessor>().GetRequiredUmbracoContext();
 
         private static IDataProtectionProvider DataProtectionProvider { get; } =

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ namespace Umbraco.Extensions`
`9`	`9`	`public static class FriendlyUrlHelperExtensions`
`10`	`10`	`{`
`11`	`11`
`12`		`- private static IUmbracoContext UmbracoContext { get; } =`
	`12`	`+ private static IUmbracoContext UmbracoContext =>`
`13`	`13`	`StaticServiceProvider.Instance.GetRequiredService<IUmbracoContextAccessor>().GetRequiredUmbracoContext();`
`14`	`14`
`15`	`15`	`private static IDataProtectionProvider DataProtectionProvider { get; } =`