Skip to content

Commit 92e535a

Browse files
andr317cMigaroeznielslyngsoe
authored
V13 QA updated locator for failing E2E test (#17825)
* Added timeouts * Nullcheck user in Content permission handlers (#17846) --------- Co-authored-by: Sven Geusens <[email protected]> Co-authored-by: Niels Lyngsø <[email protected]>
1 parent 7411c25 commit 92e535a

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/BlockGridEditor/Content/blockGridEditorContent.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ test.describe('BlockGridEditorContent', () => {
6767
await page.locator('[id="sub-view-0"]').locator('[id="title"]').fill(newContentValue);
6868
await umbracoUi.clickDataElementByElementName('sub-view-settings');
6969
// Adds text to the setting element
70+
await page.waitForTimeout(500);
7071
await page.locator('[id="sub-view-1"]').locator('[id="title"]').fill(newSettingValue);
7172
await page.locator('[label="Submit"]').click();
7273
await umbracoUi.clickElement(umbracoUi.getButtonByLabelKey(ConstantHelper.buttons.saveAndPublish));
@@ -231,7 +232,7 @@ test.describe('BlockGridEditorContent', () => {
231232
const dragFromLocator = await page.locator('[data-content-element-type-key="' + element['key'] + '"]', {hasText: bottomBlock});
232233
const dragToLocator = await page.locator('[data-content-element-type-key="' + element['key'] + '"]', {hasText: topBlock});
233234
await umbracoUi.dragAndDrop(dragFromLocator, dragToLocator, 10, -5, 15);
234-
235+
await page.waitForTimeout(500);
235236
// Assert
236237
// Checks if the BottomBlock is moved to be under TopBlock
237238
await expect(page.locator('[data-content-element-type-key="' + element['key'] + '"]').nth(1)).toContainText(bottomBlock);
@@ -393,7 +394,6 @@ test.describe('BlockGridEditorContent', () => {
393394
await umbracoUi.isSuccessNotificationVisible();
394395
// Checks if there are two blocks in the area
395396
await expect(page.locator('[data-element="property-' + blockGridAlias + '"]').locator('umb-block-grid-entry')).toHaveCount(2);
396-
397397
});
398398

399399
test('can set a maximum of required blocks in content with a block grid editor', async ({page, umbracoApi, umbracoUi}) => {
@@ -458,8 +458,8 @@ test.describe('BlockGridEditorContent', () => {
458458
await page.locator('[title="Delete"]').nth(2).click();
459459
await umbracoUi.clickElement(umbracoUi.getButtonByLabelKey('actions_delete'));
460460

461-
await page.waitForTimeout(2000);
462-
await page.getByRole('button', { name: 'Save and publish' }).click();
461+
await page.waitForTimeout(1000);
462+
await umbracoUi.clickElement(umbracoUi.getButtonByLabelKey(ConstantHelper.buttons.saveAndPublish));
463463

464464
// Assert
465465
await umbracoUi.isSuccessNotificationVisible();
@@ -477,7 +477,7 @@ test.describe('BlockGridEditorContent', () => {
477477
const dataTypeBlockGrid = new BlockGridDataTypeBuilder()
478478
.withName(blockGridName)
479479
.addBlock()
480-
// We use the a label so we can see if the block is live updated when content is being written to the element
480+
// We use the label so we can see if the block is live updated when content is being written to the element
481481
.withLabel('{{' + element.groups[0].properties[0].alias + '}}')
482482
.withContentElementTypeKey(element['key'])
483483
.withEditorSize('small')

0 commit comments

Comments
 (0)