Check for duplicate keys on media if we know it's a fresh entity (#15838)

Co-authored-by: Sven Geusens <[email protected]>

Author: Migaroez

src/Umbraco.Cms.Api.Management/Controllers/Content/ContentControllerBase.cs

@@ -64,6 +64,10 @@ protected IActionResult ContentEditingOperationStatusResult(ContentEditingOperat
                 .WithTitle("Invalid culture")
                 .WithDetail("One or more of the supplied culture codes did not match the configured languages.")
                 .Build()),
+            ContentEditingOperationStatus.DuplicateKey => BadRequest(problemDetailsBuilder
+                .WithTitle("Invalid Id")
+                .WithDetail("The supplied id is already in use.")
+                .Build()),
             ContentEditingOperationStatus.Unknown => StatusCode(
                 StatusCodes.Status500InternalServerError,
                 problemDetailsBuilder

src/Umbraco.Core/Services/MediaEditingService.cs

@@ -144,6 +144,7 @@ private ContentEditingOperationStatus Save(IMedia media, int userId)
                 // these are the only result states currently expected from Save
                 OperationResultType.Success => ContentEditingOperationStatus.Success,
                 OperationResultType.FailedCancelledByEvent => ContentEditingOperationStatus.CancelledByNotification,
+                OperationResultType.FailedDuplicateKey => ContentEditingOperationStatus.DuplicateKey,
 
                 // for any other state we'll return "unknown" so we know that we need to amend this
                 _ => ContentEditingOperationStatus.Unknown

src/Umbraco.Core/Services/MediaService.cs

@@ -756,6 +756,13 @@ public bool HasChildren(int id)
                 scope.WriteLock(Constants.Locks.MediaTree);
                 if (media.HasIdentity == false)
                 {
+                    if (_entityRepository.Get(media.Key, UmbracoObjectTypes.Media.GetGuid()) is not null)
+                    {
+                        scope.Complete();
+                        return Attempt.Fail<OperationResult?>(
+                            new OperationResult(OperationResultType.FailedDuplicateKey, eventMessages));
+                    }
+
                     media.CreatorId = userId;
                 }
 

src/Umbraco.Core/Services/OperationResultType.cs

@@ -40,5 +40,10 @@ public enum OperationResultType : byte
     /// </summary>
     NoOperation = Failed | 6, // TODO: shouldn't it be a success?
 
+    /// <summary>
+    ///     The operation could not complete due to duplicate key detection
+    /// </summary>
+    FailedDuplicateKey = Failed | 7
+
     // TODO: In the future, we might need to add more operations statuses, potentially like 'FailedByPermissions', etc...
 }

src/Umbraco.Core/Services/OperationStatus/ContentEditingOperationStatus.cs

@@ -18,5 +18,6 @@ public enum ContentEditingOperationStatus
     SortingInvalid,
     PropertyValidationError,
     InvalidCulture,
-    Unknown
+    DuplicateKey,
+    Unknown,
 }