Skip to content

Commit b392a49

Browse files
authored
V14 QA Token access fix (#16111)
* Added fixtures * Fixed existing tests * Temporary file path for updating StorageState * Fixed indentation * Bumped version * Added a storageStatePath * Deleted unnecessary fixtures * Deleted commented out code * Bumped version of testHelpers * Updated Pipeline * Bumped version * Added fixes from review * Added another wait and goToSection
1 parent cceb418 commit b392a49

File tree

7 files changed

+59
-48
lines changed

7 files changed

+59
-48
lines changed

build/azure-pipelines.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,8 @@ stages:
466466
- pwsh: |
467467
"UMBRACO_USER_LOGIN=$(UMBRACO__CMS__UNATTENDED__UNATTENDEDUSEREMAIL)
468468
UMBRACO_USER_PASSWORD=$(UMBRACO__CMS__UNATTENDED__UNATTENDEDUSERPASSWORD)
469-
URL=$(ASPNETCORE_URLS)" | Out-File .env
469+
URL=$(ASPNETCORE_URLS)
470+
STORAGE_STAGE_PATH=$(Build.SourcesDirectory)/tests/Umbraco.Tests.AcceptanceTest/playwright/.auth/user.json" | Out-File .env
470471
displayName: Generate .env
471472
workingDirectory: $(Build.SourcesDirectory)/tests/Umbraco.Tests.AcceptanceTest
472473

tests/Umbraco.Tests.AcceptanceTest/config.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ const fs = require('fs');
33

44
const properties = [
55
{
6-
description: 'Enter your umbraco superadmin username/email',
6+
description: 'Enter your Umbraco superadmin username/email',
77
name: 'username',
88
required: true
99
},
1010
{
11-
description: 'Enter your umbraco superadmin password',
11+
description: 'Enter your Umbraco superadmin password',
1212
name: 'password',
1313
hidden: true,
1414
required: true
@@ -22,7 +22,7 @@ const properties = [
2222

2323
const configPath = './.env'
2424

25-
console.log("Configure your umbraco test environment")
25+
console.log("Configure your Umbraco test environment")
2626

2727
prompt.start();
2828

@@ -31,7 +31,8 @@ prompt.get(properties, function (error, result) {
3131

3232
var fileContent = `UMBRACO_USER_LOGIN=${result.username}
3333
UMBRACO_USER_PASSWORD=${result.password}
34-
URL=${result.baseUrl || "https://localhost:44339"}`;
34+
URL=${result.baseUrl || "https://localhost:44339"}
35+
STORAGE_STAGE_PATH=${__dirname.replace(/\\/g,'/')}/playwright/.auth/user.json`;
3536

3637
fs.writeFile(configPath, fileContent, function (error) {
3738
if (error) return console.error(error);

tests/Umbraco.Tests.AcceptanceTest/package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/Umbraco.Tests.AcceptanceTest/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
},
2222
"dependencies": {
2323
"@umbraco/json-models-builders": "^2.0.5",
24-
"@umbraco/playwright-testhelpers": "^2.0.0-beta.33",
24+
"@umbraco/playwright-testhelpers": "^2.0.0-beta.38",
2525
"camelize": "^1.0.0",
2626
"dotenv": "^16.3.1",
2727
"faker": "^4.1.0",

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Script/Script.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ test.describe('Script tests', () => {
2727
await umbracoUi.script.isSuccessNotificationVisible();
2828
expect(await umbracoApi.script.doesNameExist(scriptName)).toBeTruthy();
2929
await umbracoUi.script.clickRootFolderCaretButton();
30-
await umbracoUi.script.isScriptTreeItemVisibile(scriptName);
30+
await umbracoUi.script.isScriptTreeItemVisible(scriptName);
3131
});
3232

3333
test.skip('can create a script with content', async ({umbracoApi, umbracoUi}) => {
@@ -48,7 +48,7 @@ test.describe('Script tests', () => {
4848
const scriptData = await umbracoApi.script.getByName(scriptName);
4949
expect(scriptData.content).toBe(scriptContent);
5050
await umbracoUi.script.clickRootFolderCaretButton();
51-
await umbracoUi.script.isScriptTreeItemVisibile(scriptName);
51+
await umbracoUi.script.isScriptTreeItemVisible(scriptName);
5252
});
5353

5454
test.skip('can update a script', async ({umbracoApi, umbracoUi}) => {
@@ -79,7 +79,7 @@ test.describe('Script tests', () => {
7979
// Assert
8080
await umbracoUi.script.isSuccessNotificationVisible();
8181
expect(await umbracoApi.script.doesNameExist(scriptName)).toBeFalsy();
82-
await umbracoUi.script.isScriptTreeItemVisibile(scriptName, false);
82+
await umbracoUi.script.isScriptTreeItemVisible(scriptName, false);
8383
});
8484

8585
test.skip('can rename a script', async ({umbracoApi, umbracoUi}) => {

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Script/ScriptFolder.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ test.describe('Script tests', () => {
2424
await umbracoUi.script.isSuccessNotificationVisible();
2525
expect(await umbracoApi.script.doesFolderExist(scriptFolderName)).toBeTruthy();
2626
await umbracoUi.script.clickRootFolderCaretButton();
27-
await umbracoUi.script.isScriptTreeItemVisibile(scriptFolderName);
27+
await umbracoUi.script.isScriptTreeItemVisible(scriptFolderName);
2828
});
2929

3030
test.skip('can delete a folder', async ({umbracoApi, umbracoUi}) => {
@@ -39,7 +39,7 @@ test.describe('Script tests', () => {
3939
// Assert
4040
await umbracoUi.script.isSuccessNotificationVisible();
4141
expect(await umbracoApi.script.doesFolderExist(scriptFolderName)).toBeFalsy();
42-
await umbracoUi.script.isScriptTreeItemVisibile(scriptFolderName, false);
42+
await umbracoUi.script.isScriptTreeItemVisible(scriptFolderName, false);
4343
});
4444

4545
test.skip('can create a script in a folder', async ({umbracoApi, umbracoUi}) => {
@@ -64,7 +64,7 @@ test.describe('Script tests', () => {
6464
const scriptData = await umbracoApi.script.get(scriptChildren[0].path);
6565
expect(scriptData.content).toBe(scriptContent);
6666
await umbracoUi.stylesheet.clickCaretButtonForName(scriptFolderName);
67-
await umbracoUi.script.isScriptTreeItemVisibile(scriptName);
67+
await umbracoUi.script.isScriptTreeItemVisible(scriptName);
6868
});
6969

7070
test.skip('can create a folder in a folder', async ({umbracoApi, umbracoUi}) => {
@@ -83,7 +83,7 @@ test.describe('Script tests', () => {
8383
const scriptChildren = await umbracoApi.script.getChildren('/' + scriptFolderName);
8484
expect(scriptChildren[0].path).toBe('/' + scriptFolderName + '/' + childFolderName);
8585
await umbracoUi.stylesheet.clickCaretButtonForName(scriptFolderName);
86-
await umbracoUi.script.isScriptTreeItemVisibile(childFolderName);
86+
await umbracoUi.script.isScriptTreeItemVisible(childFolderName);
8787
});
8888

8989
test.skip('can create a folder in a folder in a folder', async ({umbracoApi, umbracoUi}) => {
@@ -105,7 +105,7 @@ test.describe('Script tests', () => {
105105
const scriptChildren = await umbracoApi.script.getChildren('/' + scriptFolderName + '/' + childFolderName);
106106
expect(scriptChildren[0].path).toBe('/' + scriptFolderName + '/' + childFolderName + '/' + childOfChildFolderName);
107107
await umbracoUi.stylesheet.clickCaretButtonForName(childFolderName);
108-
await umbracoUi.script.isScriptTreeItemVisibile(childOfChildFolderName);
108+
await umbracoUi.script.isScriptTreeItemVisible(childOfChildFolderName);
109109
});
110110

111111
test.skip('can create a script in a folder in a folder', async ({umbracoApi, umbracoUi}) => {
@@ -129,6 +129,6 @@ test.describe('Script tests', () => {
129129
const scriptChildren = await umbracoApi.script.getChildren('/' + scriptFolderName + '/' + childFolderName);
130130
expect(scriptChildren[0].path).toBe('/' + scriptFolderName + '/' + childFolderName + '/' + scriptName);
131131
await umbracoUi.stylesheet.clickCaretButtonForName(childFolderName);
132-
await umbracoUi.script.isScriptTreeItemVisibile(scriptName);
132+
await umbracoUi.script.isScriptTreeItemVisible(scriptName);
133133
});
134134
});

0 commit comments

Comments
 (0)