Skip to content

Commit b6be468

Browse files
committed
Merge branch 'v15/dev' of https://github.com/umbraco/Umbraco-CMS into v15/dev
2 parents 3ec88aa + d62fe5e commit b6be468

File tree

25 files changed

+232
-1288
lines changed

25 files changed

+232
-1288
lines changed

src/Umbraco.Cms.Persistence.EFCore/Scoping/EFCoreScope.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,16 @@ public override void Dispose()
127127

128128
Locks.ClearLocks(InstanceId);
129129

130-
if (ParentScope is null)
130+
// Since we can nest EFCoreScopes in other scopes derived from CoreScope, we should check whether our ParentScope OR the base ParentScope exists.
131+
// Only if neither do do we take responsibility for ensuring the locks are cleared.
132+
// Eventually the highest parent will clear the locks.
133+
// Further, these locks are a reference to the locks of the highest parent anyway (see the constructor of CoreScope).
134+
#pragma warning disable SA1100 // Do not prefix calls with base unless local implementation exists (justification: provides additional clarify here that this is defined on the base class).
135+
if (ParentScope is null && base.HasParentScope is false)
131136
{
132137
Locks.EnsureLocksCleared(InstanceId);
133138
}
139+
#pragma warning restore SA1100 // Do not prefix calls with base unless local implementation exists
134140

135141
_efCoreScopeProvider.PopAmbientScope();
136142

src/Umbraco.Core/Scoping/CoreScope.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,8 @@ protected void SetParentScope(ICoreScope coreScope)
250250
_parentScope = coreScope;
251251
}
252252

253+
protected bool HasParentScope => _parentScope is not null;
254+
253255
protected void HandleScopedNotifications() => _notificationPublisher?.ScopeExit(Completed.HasValue && Completed.Value);
254256

255257
private void EnsureNotDisposed()

src/Umbraco.Web.UI.Client/src/packages/media/media/dropzone/dropzone-media.element.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ export class UmbDropzoneMediaElement extends UmbInputDropzoneElement {
126126
z-index: 100;
127127
border-radius: var(--uui-border-radius);
128128
border: 1px solid var(--uui-color-focus);
129+
box-sizing:border-box;
129130
}
130131
`,
131132
];

tests/Umbraco.Tests.AcceptanceTest/tests/ApiTesting/DataType/DataType.spec.ts

Lines changed: 0 additions & 105 deletions
This file was deleted.

tests/Umbraco.Tests.AcceptanceTest/tests/ApiTesting/DataType/DataTypeFolder.spec.ts

Lines changed: 0 additions & 50 deletions
This file was deleted.

tests/Umbraco.Tests.AcceptanceTest/tests/ApiTesting/Dictionary/Dictionary.spec.ts

Lines changed: 0 additions & 106 deletions
This file was deleted.

tests/Umbraco.Tests.AcceptanceTest/tests/ApiTesting/Document/Document.spec.ts

Lines changed: 0 additions & 55 deletions
This file was deleted.

0 commit comments

Comments
 (0)