Bugfix - Missing write lock

Paul Johnson · Paul Johnson · commit bdbc38e28022 · 2021-11-16T10:13:20.000Z
diff --git a/src/Umbraco.Core/Services/Implement/ContentService.cs b/src/Umbraco.Core/Services/Implement/ContentService.cs
@@ -3257,8 +3257,9 @@ public void SetPreventCleanup(int versionId, bool preventCleanup, int userId = -
             // NOTE: v9 - don't service locate
             var documentVersionRepository = Composing.Current.Factory.GetInstance<IDocumentVersionRepository>();
 
-            using (ScopeProvider.CreateScope(autoComplete: true))
+            using (var scope = ScopeProvider.CreateScope(autoComplete: true))
             {
+                scope.WriteLock(Constants.Locks.ContentTree);
                 documentVersionRepository.SetPreventCleanup(versionId, preventCleanup);
 
                 var version = documentVersionRepository.Get(versionId);

Original file line number	Diff line number	Diff line change
`@@ -3257,8 +3257,9 @@ public void SetPreventCleanup(int versionId, bool preventCleanup, int userId = -`
`3257`	`3257`	`// NOTE: v9 - don't service locate`
`3258`	`3258`	`var documentVersionRepository = Composing.Current.Factory.GetInstance<IDocumentVersionRepository>();`
`3259`	`3259`
`3260`		`- using (ScopeProvider.CreateScope(autoComplete: true))`
	`3260`	`+ using (var scope = ScopeProvider.CreateScope(autoComplete: true))`
`3261`	`3261`	`{`
	`3262`	`+ scope.WriteLock(Constants.Locks.ContentTree);`
`3262`	`3263`	`documentVersionRepository.SetPreventCleanup(versionId, preventCleanup);`
`3263`	`3264`
`3264`	`3265`	`var version = documentVersionRepository.Get(versionId);`