Fixes issues with database rebuild and the fact media was created as published. Leading to cache misses (#17169)

Author: bergmania

src/Umbraco.PublishedCache.HybridCache/DatabaseCacheRebuilder.cs

@@ -1,16 +1,24 @@
 using Umbraco.Cms.Core.PublishedCache;
+using Umbraco.Cms.Core.Scoping;
 using Umbraco.Cms.Infrastructure.HybridCache.Persistence;
 
 namespace Umbraco.Cms.Infrastructure.HybridCache;
 
 internal class DatabaseCacheRebuilder : IDatabaseCacheRebuilder
 {
     private readonly IDatabaseCacheRepository _databaseCacheRepository;
+    private readonly ICoreScopeProvider _coreScopeProvider;
 
-    public DatabaseCacheRebuilder(IDatabaseCacheRepository databaseCacheRepository)
+    public DatabaseCacheRebuilder(IDatabaseCacheRepository databaseCacheRepository, ICoreScopeProvider coreScopeProvider)
     {
         _databaseCacheRepository = databaseCacheRepository;
+        _coreScopeProvider = coreScopeProvider;
     }
 
-    public void Rebuild() => _databaseCacheRepository.Rebuild();
+    public void Rebuild()
+    {
+        using ICoreScope scope = _coreScopeProvider.CreateCoreScope();
+        _databaseCacheRepository.Rebuild();
+        scope.Complete();
+    }
 }

src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs

@@ -87,7 +87,7 @@ public async Task RefreshContentAsync(ContentCacheNode contentCacheNode, Publish
     public async Task RefreshMediaAsync(ContentCacheNode contentCacheNode)
     {
         IContentCacheDataSerializer serializer = _contentCacheDataSerializerFactory.Create(ContentCacheDataSerializerEntityType.Media);
-        await OnRepositoryRefreshed(serializer, contentCacheNode, false);
+        await OnRepositoryRefreshed(serializer, contentCacheNode, true);
     }
 
     /// <inheritdoc/>
@@ -117,20 +117,10 @@ public void Rebuild(
             }
         }
 
-        if (contentTypeIds != null)
-        {
-            RebuildContentDbCache(serializer, _nucacheSettings.Value.SqlPageSize, contentTypeIds);
-        }
+        RebuildContentDbCache(serializer, _nucacheSettings.Value.SqlPageSize, contentTypeIds);
+        RebuildMediaDbCache(serializer, _nucacheSettings.Value.SqlPageSize, mediaTypeIds);
+        RebuildMemberDbCache(serializer, _nucacheSettings.Value.SqlPageSize, memberTypeIds);
 
-        if (mediaTypeIds != null)
-        {
-            RebuildMediaDbCache(serializer, _nucacheSettings.Value.SqlPageSize, mediaTypeIds);
-        }
-
-        if (memberTypeIds != null)
-        {
-            RebuildMemberDbCache(serializer, _nucacheSettings.Value.SqlPageSize, memberTypeIds);
-        }
     }
 
     // assumes content tree lock