Nonbreaking performance tweaks (#17106)

* Avoid doing multiple lookups in dictionaries, avoid doing string interpolation & adding single char strings to a StringBuilder, made some private/internal classes & some private methods static when possible, use FrozenSet for InvalidFileNameChars

* Avoid some array + list allocations & async methods and made some private methods static

* Avoid double lookup of XML attribute (and double null check) & avoid an unneeded lookup before writing to a dictionary

* Avoid some double lookups

# Conflicts:
#	src/Umbraco.Core/Services/LocalizedTextService.cs

* Avoid double lookups

# Conflicts:
#	src/Umbraco.Core/Services/LocalizedTextService.cs

* Avoid double lookups

* List AsSpan, also to trigger a new build that hopefully goes through

* Avoid concatting strings when using writer & more static

* Updated CollectionBenchmarks to show that ToArray isn't always the fastest & Lists can be iterated nearly as fast as arrays (and that ToList is nearly as fast as ToArray on IReadOnlyLists in .NET 8)

* Fix rebase

* Use explicit types ❤️ (I thought it was the other way round...)

# Conflicts:
#	src/Umbraco.Core/Services/LocalizedTextService.cs

* Reduce number of lines in HtmlStringUtilities.Truncate to pass code quality analysis

* Avoid double lookups & allocating empty arrays

* Use native List Find instead of LINQ

Author: Henr1k80

src/Umbraco.Cms.Api.Delivery/Querying/Filters/ContainsFilterBase.cs

@@ -37,12 +37,12 @@ public FilterOption BuildFilterOption(string filter)
     {
         GroupCollection groups = QueryParserRegex.Match(filter).Groups;
 
-        if (groups.Count != 3 || groups.ContainsKey("operator") is false || groups.ContainsKey("value") is false)
+        if (groups.Count != 3 || groups.TryGetValue("operator", out Group? operatorGroup) is false || groups.TryGetValue("value", out Group? valueGroup) is false)
         {
             return DefaultFilterOption();
         }
 
-        FilterOperation? filterOperation = ParseFilterOperation(groups["operator"].Value);
+        FilterOperation? filterOperation = ParseFilterOperation(operatorGroup.Value);
         if (filterOperation.HasValue is false)
         {
             return DefaultFilterOption();
@@ -51,7 +51,7 @@ public FilterOption BuildFilterOption(string filter)
         return new FilterOption
         {
             FieldName = FieldName,
-            Values = new[] { groups["value"].Value },
+            Values = [valueGroup.Value],
             Operator = filterOperation.Value
         };
 

src/Umbraco.Cms.Api.Delivery/Services/ApiContentQueryProvider.cs

@@ -79,10 +79,14 @@ public PagedModel<Guid> ExecuteQuery(
             return new PagedModel<Guid>();
         }
 
-        Guid[] items = results
-            .Where(r => r.Values.ContainsKey(ItemIdFieldName))
-            .Select(r => Guid.Parse(r.Values[ItemIdFieldName]))
-            .ToArray();
+        List<Guid> items = [];
+        foreach (ISearchResult result in results)
+        {
+            if (result.Values.TryGetValue(ItemIdFieldName, out string? value))
+            {
+                items.Add(Guid.Parse(value));
+            }
+        }
 
         return new PagedModel<Guid>(results.TotalItemCount, items);
     }

src/Umbraco.Cms.Api.Management/Controllers/Template/Query/ExecuteTemplateQueryController.cs

@@ -98,7 +98,7 @@ private IEnumerable<IPublishedContent> BuildQuery(TemplateQueryExecuteModel mode
         if (model.RootDocument?.Id is not null)
         {
             rootContent = _publishedContentQuery.Content(model.RootDocument.Id);
-            queryExpression.Append($"Umbraco.Content(Guid.Parse(\"{model.RootDocument.Id}\"))");
+            queryExpression.Append("Umbraco.Content(Guid.Parse(\"").Append(model.RootDocument.Id).Append("\"))");
         }
         else
         {
@@ -115,7 +115,7 @@ private IEnumerable<IPublishedContent> GetRootContentQuery(TemplateQueryExecuteM
 
         if (model.DocumentTypeAlias.IsNullOrWhiteSpace() == false)
         {
-            queryExpression.Append($".ChildrenOfType(\"{model.DocumentTypeAlias}\")");
+            queryExpression.Append(".ChildrenOfType(\"").Append(model.DocumentTypeAlias).Append("\")");
             return rootContent == null
                 ? Enumerable.Empty<IPublishedContent>()
                 : rootContent.ChildrenOfType(_variationContextAccessor, _contentCache, _documentNavigationQueryService, model.DocumentTypeAlias);
@@ -176,7 +176,7 @@ string PropertyModelType(TemplateQueryPropertyType templateQueryPropertyType)
             //for review - this uses a tonized query rather then the normal linq query.
             contentQuery = contentQuery.Where(operation.Compile());
             queryExpression.Append(_indent);
-            queryExpression.Append($".Where({operation})");
+            queryExpression.Append(".Where(").Append(operation).Append(')');
         }
 
         return contentQuery;
@@ -220,7 +220,7 @@ private IEnumerable<IPublishedContent> ApplySorting(TemplateQueryExecuteSortMode
         return contentQuery;
     }
 
-    private IEnumerable<IPublishedContent> ApplyPaging(int take, IEnumerable<IPublishedContent> contentQuery, StringBuilder queryExpression)
+    private static IEnumerable<IPublishedContent> ApplyPaging(int take, IEnumerable<IPublishedContent> contentQuery, StringBuilder queryExpression)
     {
         if (take <= 0)
         {
@@ -229,7 +229,7 @@ private IEnumerable<IPublishedContent> ApplyPaging(int take, IEnumerable<IPublis
 
         contentQuery = contentQuery.Take(take);
         queryExpression.Append(_indent);
-        queryExpression.Append($".Take({take})");
+        queryExpression.Append(".Take(").Append(take).Append(')');
 
         return contentQuery;
     }

src/Umbraco.Cms.Api.Management/Mapping/ContentType/ContentTypeMapDefinition.cs

@@ -25,8 +25,8 @@ protected IEnumerable<TPropertyTypeModel> MapPropertyTypes(TContentType source)
                 {
                     Id = propertyType.Key,
                     SortOrder = propertyType.SortOrder,
-                    Container = groupKeysByPropertyKeys.ContainsKey(propertyType.Key)
-                        ? new ReferenceByIdModel(groupKeysByPropertyKeys[propertyType.Key])
+                    Container = groupKeysByPropertyKeys.TryGetValue(propertyType.Key, out Guid groupKey)
+                        ? new ReferenceByIdModel(groupKey)
                         : null,
                     Name = propertyType.Name,
                     Alias = propertyType.Alias,

src/Umbraco.Cms.Api.Management/Services/ConflictingRouteService.cs

@@ -1,4 +1,5 @@
 using System.Reflection;
+using System.Runtime.InteropServices;
 using Umbraco.Cms.Api.Management.Controllers;
 using Umbraco.Cms.Core.Composing;
 using Umbraco.Cms.Core.Services;
@@ -19,7 +20,7 @@ public class ConflictingRouteService : IConflictingRouteService
     public bool HasConflictingRoutes(out string controllerName)
     {
         var controllers = _typeLoader.GetTypes<ManagementApiControllerBase>().ToList();
-        foreach (Type controller in controllers)
+        foreach (Type controller in CollectionsMarshal.AsSpan(controllers))
         {
             Type[] potentialConflicting = controllers.Where(x => x.Name == controller.Name).ToArray();
             if (potentialConflicting.Length > 1)

src/Umbraco.Cms.Persistence.EFCore/Locking/SqlServerEFCoreDistributedLockingMechanism.cs

@@ -13,7 +13,7 @@
 
 namespace Umbraco.Cms.Persistence.EFCore.Locking;
 
-internal class SqlServerEFCoreDistributedLockingMechanism<T> : IDistributedLockingMechanism
+internal sealed class SqlServerEFCoreDistributedLockingMechanism<T> : IDistributedLockingMechanism
     where T : DbContext
 {
     private ConnectionStrings _connectionStrings;
@@ -58,7 +58,7 @@ public IDistributedLock WriteLock(int lockId, TimeSpan? obtainLockTimeout = null
         return new SqlServerDistributedLock(this, lockId, DistributedLockType.WriteLock, obtainLockTimeout.Value);
     }
 
-    private class SqlServerDistributedLock : IDistributedLock
+    private sealed class SqlServerDistributedLock : IDistributedLock
     {
         private readonly SqlServerEFCoreDistributedLockingMechanism<T> _parent;
         private readonly TimeSpan _timeout;

src/Umbraco.Cms.Persistence.EFCore/Locking/SqliteEFCoreDistributedLockingMechanism.cs

@@ -13,7 +13,7 @@
 
 namespace Umbraco.Cms.Persistence.EFCore.Locking;
 
-internal class SqliteEFCoreDistributedLockingMechanism<T> : IDistributedLockingMechanism
+internal sealed class SqliteEFCoreDistributedLockingMechanism<T> : IDistributedLockingMechanism
     where T : DbContext
 {
     private ConnectionStrings _connectionStrings;
@@ -55,7 +55,7 @@ public IDistributedLock WriteLock(int lockId, TimeSpan? obtainLockTimeout = null
         return new SqliteDistributedLock(this, lockId, DistributedLockType.WriteLock, obtainLockTimeout.Value);
     }
 
-    private class SqliteDistributedLock : IDistributedLock
+    private sealed class SqliteDistributedLock : IDistributedLock
     {
         private readonly SqliteEFCoreDistributedLockingMechanism<T> _parent;
         private readonly TimeSpan _timeout;
@@ -164,7 +164,7 @@ private void ObtainWriteLock()
             });
         }
 
-        private bool IsBusyOrLocked(SqliteException ex) =>
+        private static bool IsBusyOrLocked(SqliteException ex) =>
             ex.SqliteErrorCode
                 is raw.SQLITE_BUSY
                 or raw.SQLITE_LOCKED

src/Umbraco.Cms.Persistence.EFCore/Scoping/EFCoreDetachableScope.cs

@@ -7,7 +7,7 @@
 
 namespace Umbraco.Cms.Persistence.EFCore.Scoping;
 
-internal class EFCoreDetachableScope<TDbContext> : EFCoreScope<TDbContext> where TDbContext : DbContext
+internal sealed class EFCoreDetachableScope<TDbContext> : EFCoreScope<TDbContext> where TDbContext : DbContext
 {
     private readonly IEFCoreScopeAccessor<TDbContext> _efCoreScopeAccessor;
     private readonly EFCoreScopeProvider<TDbContext> _efCoreScopeProvider;

src/Umbraco.Cms.Persistence.EFCore/Scoping/EFCoreScopeAccessor.cs

@@ -2,7 +2,7 @@
 
 namespace Umbraco.Cms.Persistence.EFCore.Scoping;
 
-internal class EFCoreScopeAccessor<TDbContext> : IEFCoreScopeAccessor<TDbContext> where TDbContext : DbContext
+internal sealed class EFCoreScopeAccessor<TDbContext> : IEFCoreScopeAccessor<TDbContext> where TDbContext : DbContext
 {
     private readonly IAmbientEFCoreScopeStack<TDbContext> _ambientEfCoreScopeStack;
 

src/Umbraco.Cms.Persistence.EFCore/Scoping/EFCoreScopeProvider.cs

@@ -13,7 +13,7 @@
 
 namespace Umbraco.Cms.Persistence.EFCore.Scoping;
 
-internal class EFCoreScopeProvider<TDbContext> : IEFCoreScopeProvider<TDbContext> where TDbContext : DbContext
+internal sealed class EFCoreScopeProvider<TDbContext> : IEFCoreScopeProvider<TDbContext> where TDbContext : DbContext
 {
     private readonly IAmbientEFCoreScopeStack<TDbContext> _ambientEfCoreScopeStack;
     private readonly ILoggerFactory _loggerFactory;