15: Convert pagesize properly to skip and take (#18069)

* convert pagesize properly to skip and take

* Obsolete pagesize & pageIndex GetAll method

Author: Zeegaan

src/Umbraco.Core/Services/IMemberService.cs

@@ -23,6 +23,7 @@ public interface IMemberService : IMembershipMemberService, IContentServiceBase<
     /// <returns>
     ///     <see cref="IEnumerable{T}" />
     /// </returns>
+    [Obsolete("Please use the skip & take instead of pageIndex & pageSize, scheduled for removal in v17")]
     IEnumerable<IMember> GetAll(
         long pageIndex,
         int pageSize,

src/Umbraco.Infrastructure/Search/IndexingNotificationHandler.ContentType.cs

@@ -117,13 +117,15 @@ private void RefreshMemberOfMemberTypes(int[] memberTypeIds)
             while (page * pageSize < total)
             {
                 IEnumerable<IMember> memberToRefresh = _memberService.GetAll(
-                    page++, pageSize, out total, "LoginName", Direction.Ascending,
+                    page * pageSize, pageSize, out total, "LoginName", Direction.Ascending,
                     memberType.Alias);
 
                 foreach (IMember c in memberToRefresh)
                 {
                     _umbracoIndexingHandler.ReIndexForMember(c);
                 }
+
+                page++;
             }
         }
     }