Resolves issues related to the setting of a schedule for content publishing (#17868)

* Render scheduled publish and unpublish on content info workspace view.

* Populate previously saved schedule on set schedule dialog.

* Hide workspace button actions that require a saved document when the document is new.

* Convert between local and server time when saving and displaying schedule.

* Fix issues with clearing of previously set schedule.

* Updated OpenApi.json to align with APi amends.

* Added missing constant.

* Fixes following merge.

* Fixed schedule mapping for invariant content.

* Fixed display of publishing/pending changes on info workspace view.

* Removed debug code.

* fix: adds missing localization keys

fixes #18297

* chore: eslint

* fix: render only the selectAll checkbox when more than one language is present

* feat: adds last edited date

* feat: adds 'last published' date

* fix: format input datetimes to datetime-local

* fix: converts the datetime string to an ISO format before sending to the server

this way we ensure the datetime contains the offset

* chore: adds more types to ensure type safety

* chore: use initialized boolean

* fix: makes schedule modal options-based to isolate the `selection` to the actual values

* docs: fix comment

* docs: adds comment

* fix: use helper function to update selection

* revert commit to prevent breaking change

* chore: eslint

* Whitespace tidy-up

* fix: stores a copy of the prevalues to be able to update that internally before finally setting the value from the updated internal values upon submit

* chore: removes unused function

* fix: unifies any pickable filters into one function

---------

Co-authored-by: Niels Lyngsø <[email protected]>
Co-authored-by: Jacob Overgaard <[email protected]>
Co-authored-by: leekelleher <[email protected]>

Author: 4 people

src/Umbraco.Cms.Api.Management/Controllers/Document/ByKeyDocumentController.cs

@@ -1,4 +1,4 @@
-using Asp.Versioning;
+using Asp.Versioning;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc;

src/Umbraco.Cms.Api.Management/Controllers/Document/ByKeyPublishedDocumentController.cs

@@ -1,4 +1,4 @@
-using Asp.Versioning;
+using Asp.Versioning;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc;
@@ -53,6 +53,7 @@ public async Task<IActionResult> ByKeyPublished(CancellationToken cancellationTo
         }
 
         PublishedDocumentResponseModel model = await _documentPresentationFactory.CreatePublishedResponseModelAsync(content);
+
         return Ok(model);
     }
 }

src/Umbraco.Cms.Api.Management/Factories/DocumentPresentationFactory.cs

@@ -1,4 +1,4 @@
-using Umbraco.Cms.Api.Management.Mapping.Content;
+using Umbraco.Cms.Api.Management.Mapping.Content;
 using Umbraco.Cms.Api.Management.ViewModels;
 using Umbraco.Cms.Api.Management.ViewModels.Document;
 using Umbraco.Cms.Api.Management.ViewModels.Document.Item;

src/Umbraco.Cms.Api.Management/Factories/IDocumentPresentationFactory.cs

@@ -1,4 +1,4 @@
-using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.DependencyInjection;
 using Umbraco.Cms.Api.Management.ViewModels.Document;
 using Umbraco.Cms.Api.Management.ViewModels.Document.Item;
 using Umbraco.Cms.Api.Management.ViewModels.DocumentBlueprint.Item;

src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs

@@ -1,4 +1,4 @@
-using Umbraco.Cms.Api.Management.Mapping.Content;
+using Umbraco.Cms.Api.Management.Mapping.Content;
 using Umbraco.Cms.Api.Management.ViewModels.Document;
 using Umbraco.Cms.Api.Management.ViewModels.Document.Collection;
 using Umbraco.Cms.Api.Management.ViewModels.DocumentBlueprint;
@@ -119,7 +119,10 @@ private void Map(ContentScheduleCollection source, DocumentResponseModel target,
     {
         foreach (ContentSchedule schedule in source.FullSchedule)
         {
-            DocumentVariantResponseModel? variant = target.Variants.FirstOrDefault(v => v.Culture == schedule.Culture || (v.Culture.IsNullOrWhiteSpace() && schedule.Culture.IsNullOrWhiteSpace()));
+            DocumentVariantResponseModel? variant = target.Variants
+                .FirstOrDefault(v =>
+                    v.Culture == schedule.Culture ||
+                    (IsInvariant(v.Culture) && IsInvariant(schedule.Culture)));
             if (variant is null)
             {
                 continue;
@@ -136,4 +139,6 @@ private void Map(ContentScheduleCollection source, DocumentResponseModel target,
             }
         }
     }
+
+    private static bool IsInvariant(string? culture) => culture.IsNullOrWhiteSpace() || culture == Core.Constants.System.InvariantCulture;
 }

src/Umbraco.Cms.Api.Management/ViewModels/Document/DocumentVariantResponseModel.cs

@@ -1,4 +1,4 @@
-using Umbraco.Cms.Api.Management.ViewModels.Content;
+using Umbraco.Cms.Api.Management.ViewModels.Content;
 
 namespace Umbraco.Cms.Api.Management.ViewModels.Document;
 

src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts

@@ -911,21 +911,22 @@ export default {
 		videos: 'Videoer',
 		avatar: 'Avatar til',
 		header: 'Overskrift',
+		selectAll: 'Vælg alle',
 		systemField: 'system felt',
 		readOnly: 'Skrivebeskyttet',
 		restore: 'Genskab',
-		generic: 'Generic',
+		generic: 'Generisk',
 		media: 'Media',
-		nodeName: 'Node Name',
-		revert: 'Revert',
+		nodeName: 'Node navn',
+		revert: 'Fortryd',
 		umbracoInfo: 'Umbraco info',
-		shared: 'Shared',
-		success: 'Success',
-		typeName: 'Type Name',
-		validate: 'Validate',
-		lastUpdated: 'Last Updated',
-		skipToMenu: 'Skip to menu',
-		skipToContent: 'Skip to content',
+		shared: 'Delt',
+		success: 'Succes',
+		typeName: 'Type navn',
+		validate: 'Valider',
+		lastUpdated: 'Sidst opdateret',
+		skipToMenu: 'Spring til menu',
+		skipToContent: 'Spring til indhold',
 		newVersionAvailable: 'Ny version tilgængelig',
 	},
 	colors: {

src/Umbraco.Web.UI.Client/src/assets/lang/en.ts

@@ -234,7 +234,7 @@ export default {
 		createDateDesc: 'Date/time this document was created',
 		documentType: 'Document Type',
 		editing: 'Editing',
-		expireDate: 'Remove at',
+		expireDate: 'Remove At',
 		itemChanged: 'This item has been changed after publication',
 		itemNotPublished: 'This item is not published',
 		lastPublished: 'Last published',
@@ -269,8 +269,8 @@ export default {
 		publishDescendantsWithVariantsHelp:
 			'Publish variants and variants of same type underneath and thereby making their content publicly available.',
 		noVariantsToProcess: 'There are no available variants',
-		releaseDate: 'Publish at',
-		unpublishDate: 'Unpublish at',
+		releaseDate: 'Publish At',
+		unpublishDate: 'Unpublish At',
 		removeDate: 'Clear Date',
 		setDate: 'Set date',
 		sortDone: 'Sortorder is updated',
@@ -952,8 +952,10 @@ export default {
 		header: 'Header',
 		systemField: 'system field',
 		lastUpdated: 'Last Updated',
+		selectAll: 'Select all',
 		skipToMenu: 'Skip to menu',
 		skipToContent: 'Skip to content',
+		readOnly: 'Read-only',
 		restore: 'Restore',
 		primary: 'Primary',
 		change: 'Change',
@@ -976,7 +978,6 @@ export default {
 		addChild: 'Add child',
 		editDataType: 'Edit data type',
 		navigateSections: 'Navigate sections',
-		selectAll: 'Select all',
 		shortcut: 'Shortcuts',
 		showShortcuts: 'show shortcuts',
 		toggleListView: 'Toggle list view',

src/Umbraco.Web.UI.Client/src/libs/observable-api/utils/append-to-frozen-array.function.ts

@@ -1,7 +1,6 @@
 /**
  * @function appendToFrozenArray
- * @param {Array<T>} source - An Array which is frozen and should be updated.
- * @param data
+ * @param {Array<T>} data - An Array which is frozen and should be updated.
  * @param {T} entry - A new entry to append to the array.
  * @param {(entry: T) => unknown} getUniqueMethod - Method to retrieve a value of an entry that is unique to it. This enables the method to replace existing value if it matches the unique value.
  * @returns {Array<T>} - Returns a new array with the new entry appended.

src/Umbraco.Web.UI.Client/src/packages/core/workspace/conditions/const.ts

@@ -4,7 +4,7 @@
 export const UMB_WORKSPACE_HAS_COLLECTION_CONDITION_ALIAS = 'Umb.Condition.WorkspaceHasCollection';
 
 /**
- * [Deperecated] Workspace has collection condition alias
+ * [Deprecated] Workspace has collection condition alias
  * @deprecated Use {UMB_WORKSPACE_HAS_COLLECTION_CONDITION_ALIAS} instead. This will be removed in Umbraco 16.
  */
 export const UMB_WORKSPACE_HAS_COLLECTION_CONDITION = UMB_WORKSPACE_HAS_COLLECTION_CONDITION_ALIAS;
@@ -15,7 +15,7 @@ export const UMB_WORKSPACE_HAS_COLLECTION_CONDITION = UMB_WORKSPACE_HAS_COLLECTI
 export const UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION_ALIAS = 'Umb.Condition.WorkspaceEntityIsNew';
 
 /**
- * [Deperecated] Workspace entity is new condition alias
+ * [Deprecated] Workspace entity is new condition alias
  * @deprecated Use {UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION_ALIAS} instead. This will be removed in Umbraco 16.
  */
 export const UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION = UMB_WORKSPACE_ENTITY_IS_NEW_CONDITION_ALIAS;