Fixing minor things in accordance with CR

Author: NillasKA

src/Umbraco.Cms.Api.Management/Services/Signs/HasScheduleSignProvider.cs

@@ -1,7 +1,8 @@
+using Serilog.Core;
 using Umbraco.Cms.Api.Management.ViewModels.Tree;
 using Umbraco.Cms.Core.Models.Entities;
 using Umbraco.Cms.Core.Services;
-using Umbraco.Extensions;
+using Constants = Umbraco.Cms.Core.Constants;
 
 namespace Umbraco.Cms.Api.Management.Services.Signs;
 
@@ -10,7 +11,7 @@ namespace Umbraco.Cms.Api.Management.Services.Signs;
 /// </summary>
 internal class HasScheduleSignProvider : ISignProvider
 {
-    private const string Alias = ISignProvider.Prefix + "ScheduledForPublish";
+    private const string Alias = Constants.Conventions.Signs.Prefix + "ScheduledForPublish";
 
     private readonly IContentService _contentService;
 

src/Umbraco.Cms.Api.Management/Services/Signs/ISignProvider.cs

@@ -8,11 +8,6 @@ namespace Umbraco.Cms.Api.Management.Services.Signs;
 /// </summary>
 public interface ISignProvider
 {
-    /// <summary>
-    /// Prefix of each sign alias.
-    /// </summary>
-    const string Prefix = "Umb.";
-
     /// <summary>
     /// Gets a value indicating whether this provider can provide tree signs for the specified item type.
     /// </summary>

src/Umbraco.Cms.Api.Management/Services/Signs/IsProtectedSignProvider.cs

@@ -1,11 +1,12 @@
 using Umbraco.Cms.Api.Management.ViewModels.Tree;
+using Umbraco.Cms.Core;
 using Umbraco.Cms.Core.Models.Entities;
 
 namespace Umbraco.Cms.Api.Management.Services.Signs;
 
 internal class IsProtectedSignProvider : ISignProvider
 {
-    private const string Alias = ISignProvider.Prefix + "IsProtected";
+    private const string Alias = Constants.Conventions.Signs.Prefix + "IsProtected";
 
     /// <inheritdoc/>>
     public bool CanProvideTreeSigns<TItem>() => typeof(TItem) == typeof(DocumentTreeItemResponseModel);

src/Umbraco.Core/Constants-Conventions.cs

@@ -303,5 +303,16 @@ public static class Udi
         {
             public const string Prefix = "umb://";
         }
+
+        /// <summary>
+        ///     Constants for all Sign aliases.
+        /// </summary>
+        public static class Signs
+        {
+            /// <summary>
+            ///     Prefix for all signs aliases.
+            /// </summary>
+            public const string Prefix = "Umb.";
+        }
     }
 }

tests/Umbraco.Tests.UnitTests/Umbraco.Cms.Api.Management/Services/Signs/IsProtectedSignProviderTest.cs renamed to tests/Umbraco.Tests.UnitTests/Umbraco.Cms.Api.Management/Services/Signs/IsProtectedSignProviderTests.cs

@@ -1,14 +1,12 @@
-using Moq;
-using NUnit.Framework;
+using NUnit.Framework;
 using Umbraco.Cms.Api.Management.Services.Signs;
 using Umbraco.Cms.Api.Management.ViewModels.Tree;
 using Umbraco.Cms.Core.Models.Entities;
-using Umbraco.Cms.Core.Services;
 
 namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Cms.Api.Management.Services.Signs;
 
 [TestFixture]
-internal class IsProtectedSignProviderTest
+internal class IsProtectedSignProviderTests
 {
     [Test]
     public async Task IsProtectedSignProvider_Should_Populate_Signs()