V17 - Removing obsoleted code from Umbraco.Core (#20009)

* Removing obsoleted code from ApiMediaQueryService.cs

* Removing obsoleted code from ApiRichTextMarkupParserTests.cs

* Removing obsoleted code from ContentCacheRefresher.cs

* Removing obsoleted code from ContentFinderByUrlAlias.cs and adjusting its tests to use the new logic

* Removing obsoleted code from ContentFinderByUrl.cs & its dependencies

* Removing obsoleted code from ApiRichTextMarkupParserTests.cs

* Removing obsoleted code from DocumentCache.cs & its dependencies

* Removing obsoleted code from MediaCache.cs & its dependencies

* Removing obsoleted code from PublishedCacheBase.cs & its dependencies

* Removing obsoleted code from RenderNoContentController.cs and its tests

* Removing obsoleted code from UmbracoRouteValueTransformer.cs

* Removing obsoleted constructors from DefaultUrlProvider.cs

* Removing accidental bookmark

* Introducing a helper method to get the root keys in ApiMediaQueryService.cs

* Removing obsoleted code from Cache classes

* Removing unused imports

* Refactoring to meet the CR

* Added attribute to controller

* Fixing missing using statement

* Removing obsoleted constructor from ExternalLoginService.cs and making usages fit

* Removing obsoleted method from IContentTypeFilter.cs

* Removing obsoleted methods from IContentEditingService.cs

* Removing obosoleted code from DocumentUrlService.cs

* Removed obsoleted code from DataTypeService.cs

* Removed obsoleted code from PublishStatusService.cs

* Removing obsoleted code from the IContentPublishingService.cs and its dependencies. Also implementing a TODO in the service implementation

* Removing obsoleted code from IRelationService.cs

* Removing obsoleted code from ContentPublishingService.cs

* Removing obsoleted code from ContentEditingService.cs

* Removing obsoleted code from Constants-DataTypes.cs

* Removing obsoleted code from IAction.cs and its implementations

* Removing obsoleted code from IContentService.cs

* Removing obsoleted code from DomainUtilities.cs

* Removing obsoleted code from IIndexedEntitySearchService.cs and dependencies

* Removing obsoleted code from UrlProvider.cs

* Removing obsoleted code from AliasUrlProvider.cs

* Removing obsoleted code from ApiContentRouteBuilder.cs

* Removing obsoleted code from ApiPublishedContentCache.cs

* Removing obsoleted class TemplateQueryResult.cs

* Removing obsoleted code from ApiContentBuilder.cs

* Removing obsoleted code from HealthCheck.cs

* Removing obsoleted code from ContentTypeEditingService.cs

* Removing obsoleted code from NewDefaultUrlProvider.cs

* Removing obsoleted code from PublishedElementPropertyBase.cs

* Removing obsoleted code from WebhookRequestService.cs

* Bumping to obsolete in V18, due to usage in class that will be removed in V18

* Removing obsoleted code from PropertyValidationService.cs

* Removing obsoleted code from AddUnroutableContentWarningsWhenPublishingNotificationHandler.cs

* Removing obsoleted code from IMemberService.cs

* Removing obsoleted code from DocumentCache.cs

Author: NillasKA

src/Umbraco.Cms.Api.Management/Controllers/Member/Item/SearchMemberItemController.cs

@@ -24,15 +24,15 @@ public SearchMemberItemController(IIndexedEntitySearchService indexedEntitySearc
     [HttpGet("search")]
     [MapToApiVersion("1.0")]
     [ProducesResponseType(typeof(PagedModel<MemberItemResponseModel>), StatusCodes.Status200OK)]
-    public Task<IActionResult> SearchWithAllowedTypes(CancellationToken cancellationToken, string query, int skip = 0, int take = 100, [FromQuery]IEnumerable<Guid>? allowedMemberTypes = null)
+    public async Task<IActionResult> SearchWithAllowedTypes(CancellationToken cancellationToken, string query, int skip = 0, int take = 100, [FromQuery]IEnumerable<Guid>? allowedMemberTypes = null)
     {
-        PagedModel<IEntitySlim> searchResult = _indexedEntitySearchService.Search(UmbracoObjectTypes.Member, query, null, allowedMemberTypes, skip, take);
+        PagedModel<IEntitySlim> searchResult = await _indexedEntitySearchService.SearchAsync(UmbracoObjectTypes.Member, query, null, allowedMemberTypes, false, "*", skip, take);
         var result = new PagedModel<MemberItemResponseModel>
         {
             Items = searchResult.Items.OfType<IMemberEntitySlim>().Select(_memberPresentationFactory.CreateItemResponseModel),
-            Total = searchResult.Total
+            Total = searchResult.Total,
         };
 
-        return Task.FromResult<IActionResult>(Ok(result));
+        return await Task.FromResult<IActionResult>(Ok(result));
     }
 }

src/Umbraco.Core/Actions/ActionAssignDomain.cs

@@ -20,12 +20,6 @@ public class ActionAssignDomain : IAction
     /// <inheritdoc/>
     public string Alias => ActionAlias;
 
-    /// <inheritdoc />
-    public string Category => Constants.Conventions.PermissionCategories.AdministrationCategory;
-
-    /// <inheritdoc />
-    public string Icon => "icon-home";
-
     /// <inheritdoc />
     public bool ShowInNotifier => false;
 

src/Umbraco.Core/Actions/ActionBrowse.cs

@@ -33,11 +33,4 @@ public class ActionBrowse : IAction
 
     /// <inheritdoc />
     public bool CanBePermissionAssigned => true;
-
-    /// <inheritdoc />
-    public string Icon => string.Empty;
-
-
-    /// <inheritdoc />
-    public string Category => Constants.Conventions.PermissionCategories.ContentCategory;
 }

src/Umbraco.Core/Actions/ActionCopy.cs

@@ -20,12 +20,6 @@ public class ActionCopy : IAction
     /// <inheritdoc/>
     public string Alias => ActionAlias;
 
-    /// <inheritdoc />
-    public string Category => Constants.Conventions.PermissionCategories.StructureCategory;
-
-    /// <inheritdoc />
-    public string Icon => "icon-documents";
-
     /// <inheritdoc />
     public bool ShowInNotifier => true;
 

src/Umbraco.Core/Actions/ActionCreateBlueprintFromContent.cs

@@ -25,10 +25,4 @@ public class ActionCreateBlueprintFromContent : IAction
 
     /// <inheritdoc />
     public bool CanBePermissionAssigned => true;
-
-    /// <inheritdoc />
-    public string Icon => Constants.Icons.Blueprint;
-
-    /// <inheritdoc />
-    public string Category => Constants.Conventions.PermissionCategories.ContentCategory;
 }

src/Umbraco.Core/Actions/ActionDelete.cs

@@ -20,12 +20,6 @@ public class ActionDelete : IAction
     /// <inheritdoc/>
     public string Alias => ActionAlias;
 
-    /// <inheritdoc/>
-    public string Category => Constants.Conventions.PermissionCategories.ContentCategory;
-
-    /// <inheritdoc/>
-    public string Icon => "icon-delete";
-
     /// <inheritdoc/>
     public bool ShowInNotifier => true;
 

src/Umbraco.Core/Actions/ActionDocumentPropertyRead.cs

@@ -19,11 +19,5 @@ public class ActionDocumentPropertyRead : IAction
 
     /// <inheritdoc />
     public bool CanBePermissionAssigned => true;
-
-    /// <inheritdoc />
-    public string Icon => string.Empty;
-
-    /// <inheritdoc />
-    public string Category => Constants.Conventions.PermissionCategories.OtherCategory;
 }
 

src/Umbraco.Core/Actions/ActionDocumentPropertyWrite.cs

@@ -19,11 +19,5 @@ public class ActionDocumentPropertyWrite : IAction
 
     /// <inheritdoc />
     public bool CanBePermissionAssigned => true;
-
-    /// <inheritdoc />
-    public string Icon => string.Empty;
-
-    /// <inheritdoc />
-    public string Category => Constants.Conventions.PermissionCategories.OtherCategory;
 }
 

src/Umbraco.Core/Actions/ActionMove.cs

@@ -20,12 +20,6 @@ public class ActionMove : IAction
     /// <inheritdoc/>
     public string Alias => ActionAlias;
 
-    /// <inheritdoc />
-    public string Category => Constants.Conventions.PermissionCategories.StructureCategory;
-
-    /// <inheritdoc />
-    public string Icon => "icon-enter";
-
     /// <inheritdoc />
     public bool ShowInNotifier => true;
 

src/Umbraco.Core/Actions/ActionNew.cs

@@ -20,15 +20,9 @@ public class ActionNew : IAction
     /// <inheritdoc/>
     public string Alias => ActionAlias;
 
-    /// <inheritdoc />
-    public string Icon => "icon-add";
-
     /// <inheritdoc />
     public bool ShowInNotifier => true;
 
     /// <inheritdoc />
     public bool CanBePermissionAssigned => true;
-
-    /// <inheritdoc />
-    public string Category => Constants.Conventions.PermissionCategories.ContentCategory;
 }