Skip to content

Commit de282d0

Browse files
AndyButlandkjac
authored andcommitted
Reverts UI updates from publish with descendants dialog (15) (#18646)
* Reverts UI updates from publish with descendants dialog. * Removed unused variable.
1 parent 3586f13 commit de282d0

File tree

12 files changed

+1
-53
lines changed

12 files changed

+1
-53
lines changed

src/Umbraco.Cms.Api.Management/Controllers/Document/PublishDocumentWithDescendantsController.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,6 @@ private static PublishBranchFilter BuildPublishBranchFilter(PublishDocumentWithD
6969
publishBranchFilter |= PublishBranchFilter.IncludeUnpublished;
7070
}
7171

72-
if (requestModel.ForceRepublish)
73-
{
74-
publishBranchFilter |= PublishBranchFilter.ForceRepublish;
75-
}
76-
7772
return publishBranchFilter;
7873
}
7974
}

src/Umbraco.Cms.Api.Management/OpenApi.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42795,17 +42795,13 @@
4279542795
"PublishDocumentWithDescendantsRequestModel": {
4279642796
"required": [
4279742797
"cultures",
42798-
"forceRepublish",
4279942798
"includeUnpublishedDescendants"
4280042799
],
4280142800
"type": "object",
4280242801
"properties": {
4280342802
"includeUnpublishedDescendants": {
4280442803
"type": "boolean"
4280542804
},
42806-
"forceRepublish": {
42807-
"type": "boolean"
42808-
},
4280942805
"cultures": {
4281042806
"type": "array",
4281142807
"items": {

src/Umbraco.Cms.Api.Management/ViewModels/Document/PublishDocumentWithDescendantsRequestModel.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,5 @@ public class PublishDocumentWithDescendantsRequestModel
44
{
55
public bool IncludeUnpublishedDescendants { get; set; }
66

7-
public bool ForceRepublish { get; set; }
8-
97
public required IEnumerable<string> Cultures { get; set; }
108
}

src/Umbraco.Web.UI.Client/src/assets/lang/da-dk.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -298,9 +298,6 @@ export default {
298298
removeTextBox: 'Fjern denne tekstboks',
299299
contentRoot: 'Indholdsrod',
300300
includeUnpublished: 'Inkluder ikke-udgivet indhold.',
301-
forceRepublish: 'Udgiv uændrede elementer.',
302-
forceRepublishWarning: 'ADVARSEL: Udgivelse af alle sider under denne i indholdstræet, uanset om de er ændret eller ej, kan være en ressourcekrævende og langvarig proces.',
303-
forceRepublishAdvisory: 'Dette bør ikke være nødvendigt under normale omstændigheder, så fortsæt kun med denne handling, hvis du er sikker på, at det er nødvendigt.',
304301
isSensitiveValue:
305302
'Denne værdi er skjult.Hvis du har brug for adgang til at se denne værdi, bedes du\n kontakte din web-administrator.\n ',
306303
isSensitiveValue_short: 'Denne værdi er skjult.',

src/Umbraco.Web.UI.Client/src/assets/lang/en-us.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -320,9 +320,6 @@ export default {
320320
removeTextBox: 'Remove this text box',
321321
contentRoot: 'Content root',
322322
includeUnpublished: 'Include unpublished content items.',
323-
forceRepublish: 'Publish unchanged items.',
324-
forceRepublishWarning: 'WARNING: Publishing all pages below this one in the content tree, whether or not they have changed, can be an expensive and long-running operation.',
325-
forceRepublishAdvisory: 'This should not be necessary in normal circumstances so please only proceed with this option selected if you are certain it is required.',
326323
isSensitiveValue:
327324
'This value is hidden. If you need access to view this value please contact your\n website administrator.\n ',
328325
isSensitiveValue_short: 'This value is hidden.',

src/Umbraco.Web.UI.Client/src/assets/lang/en.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -317,9 +317,6 @@ export default {
317317
removeTextBox: 'Remove this text box',
318318
contentRoot: 'Content root',
319319
includeUnpublished: 'Include unpublished content items.',
320-
forceRepublish: 'Publish unchanged items.',
321-
forceRepublishWarning: 'WARNING: Publishing all pages below this one in the content tree, whether or not they have changed, can be an expensive and long-running operation.',
322-
forceRepublishAdvisory: 'This should not be necessary in normal circumstances so please only proceed with this option selected if you are certain it is required.',
323320
isSensitiveValue:
324321
'This value is hidden. If you need access to view this value please contact your\n website administrator.\n ',
325322
isSensitiveValue_short: 'This value is hidden.',

src/Umbraco.Web.UI.Client/src/external/backend-api/src/types.gen.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2050,7 +2050,6 @@ export type PublishDocumentRequestModel = {
20502050

20512051
export type PublishDocumentWithDescendantsRequestModel = {
20522052
includeUnpublishedDescendants: boolean;
2053-
forceRepublish: boolean;
20542053
cultures: Array<(string)>;
20552054
};
20562055

src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/publish-with-descendants/modal/document-publish-with-descendants-modal.element.ts

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import type {
55
UmbDocumentPublishWithDescendantsModalValue,
66
} from './document-publish-with-descendants-modal.token.js';
77
import { css, customElement, html, state } from '@umbraco-cms/backoffice/external/lit';
8-
import { umbConfirmModal, UmbModalBaseElement } from '@umbraco-cms/backoffice/modal';
8+
import { UmbModalBaseElement } from '@umbraco-cms/backoffice/modal';
99
import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
1010
import { UmbSelectionManager } from '@umbraco-cms/backoffice/utils';
1111

@@ -18,7 +18,6 @@ export class UmbDocumentPublishWithDescendantsModalElement extends UmbModalBaseE
1818
> {
1919
#selectionManager = new UmbSelectionManager<string>(this);
2020
#includeUnpublishedDescendants = false;
21-
#forceRepublish = false;
2221

2322
@state()
2423
_options: Array<UmbDocumentVariantOptionModel> = [];
@@ -84,25 +83,11 @@ export class UmbDocumentPublishWithDescendantsModalElement extends UmbModalBaseE
8483
this.#includeUnpublishedDescendants = !this.#includeUnpublishedDescendants;
8584
}
8685

87-
async #onForceRepublishChange() {
88-
this.#forceRepublish = !this.#forceRepublish;
89-
}
90-
9186
async #submit() {
9287

93-
if (this.#forceRepublish) {
94-
await umbConfirmModal(this, {
95-
headline: this.localize.term('content_forceRepublishWarning'),
96-
content: this.localize.term('content_forceRepublishAdvisory'),
97-
color: 'warning',
98-
confirmLabel: this.localize.term('actions_publish'),
99-
});
100-
}
101-
10288
this.value = {
10389
selection: this.#selectionManager.getSelection(),
10490
includeUnpublishedDescendants: this.#includeUnpublishedDescendants,
105-
forceRepublish: this.#forceRepublish,
10691
};
10792
this.modalContext?.submit();
10893
}
@@ -143,14 +128,6 @@ export class UmbDocumentPublishWithDescendantsModalElement extends UmbModalBaseE
143128
@change=${this.#onIncludeUnpublishedDescendantsChange}></uui-toggle>
144129
</uui-form-layout-item>
145130
146-
<uui-form-layout-item>
147-
<uui-toggle
148-
id="forceRepublish"
149-
label=${this.localize.term('content_forceRepublish')}
150-
?checked=${this.value?.forceRepublish}
151-
@change=${this.#onForceRepublishChange}></uui-toggle>
152-
</uui-form-layout-item>
153-
154131
<div slot="actions">
155132
<uui-button label=${this.localize.term('general_close')} @click=${this.#close}></uui-button>
156133
<uui-button

src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/publish-with-descendants/modal/document-publish-with-descendants-modal.token.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ export interface UmbDocumentPublishWithDescendantsModalData extends UmbDocumentV
88

99
export interface UmbDocumentPublishWithDescendantsModalValue extends UmbDocumentVariantPickerValue {
1010
includeUnpublishedDescendants?: boolean;
11-
forceRepublish?: boolean;
1211
}
1312

1413
export const UMB_DOCUMENT_PUBLISH_WITH_DESCENDANTS_MODAL = new UmbModalToken<

src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/repository/document-publishing.repository.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,12 @@ export class UmbDocumentPublishingRepository extends UmbRepositoryBase {
7171
* @param id
7272
* @param variantIds
7373
* @param includeUnpublishedDescendants
74-
* @param forceRepublish
7574
* @memberof UmbDocumentPublishingRepository
7675
*/
7776
async publishWithDescendants(
7877
id: string,
7978
variantIds: Array<UmbVariantId>,
8079
includeUnpublishedDescendants: boolean,
81-
forceRepublish: boolean,
8280
) {
8381
if (!id) throw new Error('id is missing');
8482
if (!variantIds) throw new Error('variant IDs are missing');
@@ -88,7 +86,6 @@ export class UmbDocumentPublishingRepository extends UmbRepositoryBase {
8886
id,
8987
variantIds,
9088
includeUnpublishedDescendants,
91-
forceRepublish,
9289
);
9390

9491
if (!error) {

0 commit comments

Comments
 (0)