SectionSidebarContextMenu: Delete element and methods for interaction (#20399)

Delete sction-sidebar-context-menu element + context methods

Author: madsrasmussen

src/Umbraco.Web.UI.Client/src/packages/core/section/index.ts

@@ -3,7 +3,6 @@ export * from './constants.js';
 export * from './default/default-section.element.js';
 export * from './section-main/index.js';
 export * from './section-picker-modal/section-picker-modal.token.js';
-export * from './section-sidebar-context-menu/index.js';
 export * from './section-sidebar/index.js';
 export * from './section.context.js';
 export * from './section.context.token.js';

src/Umbraco.Web.UI.Client/src/packages/core/section/section-sidebar-context-menu/index.ts

@@ -1,2 +1,2 @@
-export * from './section-sidebar.context.js';
 export * from './section-sidebar.element.js';
+export * from './section-sidebar.context.token.js';

src/Umbraco.Web.UI.Client/src/packages/core/section/section-sidebar-context-menu/section-sidebar-context-menu.element.ts

@@ -0,0 +1,4 @@
+import type { UmbSectionSidebarContext } from './section-sidebar.context.js';
+import { UmbContextToken } from '@umbraco-cms/backoffice/context-api';
+
+export const UMB_SECTION_SIDEBAR_CONTEXT = new UmbContextToken<UmbSectionSidebarContext>('UmbSectionSidebarContext');

src/Umbraco.Web.UI.Client/src/packages/core/section/section-sidebar/index.ts

@@ -1,53 +1,9 @@
-import type { UmbOpenContextMenuArgs } from './types.js';
-import { UmbContextToken } from '@umbraco-cms/backoffice/context-api';
+import { UMB_SECTION_SIDEBAR_CONTEXT } from './section-sidebar.context.token.js';
 import { UmbContextBase } from '@umbraco-cms/backoffice/class-api';
 import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
-import { UmbStringState, UmbBooleanState } from '@umbraco-cms/backoffice/observable-api';
 
 export class UmbSectionSidebarContext extends UmbContextBase {
-	#contextMenuIsOpen = new UmbBooleanState(false);
-	contextMenuIsOpen = this.#contextMenuIsOpen.asObservable();
-
-	#entityType = new UmbStringState<undefined>(undefined);
-	entityType = this.#entityType.asObservable();
-
-	#unique = new UmbStringState<null | undefined>(undefined);
-	unique = this.#unique.asObservable();
-
-	#headline = new UmbStringState<undefined>(undefined);
-	headline = this.#headline.asObservable();
-
-	#contextElement: Element | undefined = undefined;
-
 	constructor(host: UmbControllerHost) {
 		super(host, UMB_SECTION_SIDEBAR_CONTEXT);
 	}
-
-	toggleContextMenu(host: Element, args: UmbOpenContextMenuArgs) {
-		this.openContextMenu(host, args);
-	}
-
-	// TODO: we wont get notified about tree item name changes because we don't have a subscription
-	// we need to figure out how we best can handle this when we only know the entity and unique id
-	openContextMenu(host: Element, args: UmbOpenContextMenuArgs) {
-		this.#entityType.setValue(args.entityType);
-		this.#unique.setValue(args.unique);
-		this.#headline.setValue(args.headline);
-		this.#contextMenuIsOpen.setValue(true);
-		this.#contextElement = host;
-	}
-
-	closeContextMenu() {
-		this.#contextMenuIsOpen.setValue(false);
-		this.#entityType.setValue(undefined);
-		this.#unique.setValue(undefined);
-		this.#headline.setValue(undefined);
-		this.#contextElement = undefined;
-	}
-
-	getContextElement() {
-		return this.#contextElement;
-	}
 }
-
-export const UMB_SECTION_SIDEBAR_CONTEXT = new UmbContextToken<UmbSectionSidebarContext>('UmbSectionSidebarContext');

src/Umbraco.Web.UI.Client/src/packages/core/section/section-sidebar/section-sidebar.context.token.ts

@@ -12,7 +12,7 @@ import { UmbBooleanState, UmbObjectState, UmbStringState } from '@umbraco-cms/ba
 import { UmbContextBase } from '@umbraco-cms/backoffice/class-api';
 import { UmbDeprecation, debounce } from '@umbraco-cms/backoffice/utils';
 import { UmbParentEntityContext } from '@umbraco-cms/backoffice/entity';
-import { UMB_SECTION_CONTEXT, UMB_SECTION_SIDEBAR_CONTEXT } from '@umbraco-cms/backoffice/section';
+import { UMB_SECTION_CONTEXT } from '@umbraco-cms/backoffice/section';
 import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
 import type { UmbEntityModel, UmbEntityUnique } from '@umbraco-cms/backoffice/entity';
 
@@ -69,7 +69,6 @@ export abstract class UmbTreeItemContextBase<
 	public treeContext?: typeof UMB_TREE_CONTEXT.TYPE;
 
 	#sectionContext?: typeof UMB_SECTION_CONTEXT.TYPE;
-	#sectionSidebarContext?: typeof UMB_SECTION_SIDEBAR_CONTEXT.TYPE;
 
 	#parentContext = new UmbParentEntityContext(this);
 
@@ -172,18 +171,6 @@ export abstract class UmbTreeItemContextBase<
 	 */
 	public loadNextItems = (): Promise<void> => this.#treeItemChildrenManager.loadNextChildren();
 
-	public toggleContextMenu() {
-		if (!this.getTreeItem() || !this.entityType || this.unique === undefined) {
-			throw new Error('Could not request children, tree item is not set');
-		}
-
-		this.#sectionSidebarContext?.toggleContextMenu(this.getHostElement(), {
-			entityType: this.entityType,
-			unique: this.unique,
-			headline: this.getTreeItem()?.name || '',
-		});
-	}
-
 	/**
 	 * Selects the tree item
 	 * @memberof UmbTreeItemContextBase
@@ -241,10 +228,6 @@ export abstract class UmbTreeItemContextBase<
 			this.#observeSectionPath();
 		});
 
-		this.consumeContext(UMB_SECTION_SIDEBAR_CONTEXT, (instance) => {
-			this.#sectionSidebarContext = instance;
-		});
-
 		this.consumeContext(UMB_TREE_CONTEXT, (treeContext) => {
 			this.treeContext = treeContext;
 			this.#observeIsSelectable();

src/Umbraco.Web.UI.Client/src/packages/core/section/section-sidebar/section-sidebar.context.ts

@@ -25,7 +25,6 @@ export interface UmbTreeItemContext<TreeItemType extends UmbTreeItemModel = UmbT
 	targetPagination: UmbTargetPaginationManager;
 	getTreeItem(): TreeItemType | undefined;
 	setTreeItem(treeItem: TreeItemType | undefined): void;
-	toggleContextMenu(): void;
 	select(): void;
 	deselect(): void;
 	constructPath(pathname: string, entityType: string, unique: string): string;