Skip to content

Commit e634c81

Browse files
committed
Obsoletes events added for local database initialization for Umbraco Cloud that are no longer required.
1 parent f5ea5df commit e634c81

File tree

3 files changed

+17
-1
lines changed

3 files changed

+17
-1
lines changed

src/Umbraco.Core/Notifications/UmbracoApplicationComponentsInstallingNotification.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,22 @@
11
// Copyright (c) Umbraco.
22
// See LICENSE for more details.
33

4+
using System;
5+
46
namespace Umbraco.Cms.Core.Notifications
57
{
8+
// TODO (V10): Remove this class.
9+
610
/// <summary>
711
/// Notification that occurs during the Umbraco boot process, before instances of <see cref="IComponent"/> initialize.
812
/// </summary>
13+
[Obsolete("This notification was added to the core runtime start-up as a hook for Umbraco Cloud local connection string and database setup. " +
14+
"Following re-work they are no longer used (from Deploy 9.2.0)." +
15+
"Given they are non-documented and no other use is expected, they can be removed in the next major release")]
916
public class UmbracoApplicationComponentsInstallingNotification : INotification
1017
{
1118
/// <summary>
12-
/// Initializes a new instance of the <see cref="UmbracoApplicationStartingNotification"/> class.
19+
/// Initializes a new instance of the <see cref="UmbracoApplicationComponentsInstallingNotification"/> class.
1320
/// </summary>
1421
/// <param name="runtimeLevel">The runtime level</param>
1522
public UmbracoApplicationComponentsInstallingNotification(RuntimeLevel runtimeLevel) => RuntimeLevel = runtimeLevel;

src/Umbraco.Core/Notifications/UmbracoApplicationMainDomAcquiredNotification.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,18 @@
11
// Copyright (c) Umbraco.
22
// See LICENSE for more details.
33

4+
using System;
5+
46
namespace Umbraco.Cms.Core.Notifications
57
{
8+
// TODO (V10): Remove this class.
9+
610
/// <summary>
711
/// Notification that occurs during Umbraco boot after the MainDom has been acquired.
812
/// </summary>
13+
[Obsolete("This notification was added to the core runtime start-up as a hook for Umbraco Cloud local connection string and database setup. " +
14+
"Following re-work they are no longer used (from Deploy 9.2.0)." +
15+
"Given they are non-documented and no other use is expected, they can be removed in the next major release")]
916
public class UmbracoApplicationMainDomAcquiredNotification : INotification
1017
{
1118
/// <summary>

src/Umbraco.Infrastructure/Runtime/CoreRuntime.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ public async Task StartAsync(CancellationToken cancellationToken)
133133
// acquire the main domain - if this fails then anything that should be registered with MainDom will not operate
134134
AcquireMainDom();
135135

136+
// TODO (V10): Remove this obsoleted notification publish.
136137
await _eventAggregator.PublishAsync(new UmbracoApplicationMainDomAcquiredNotification(), cancellationToken);
137138

138139
// notify for unattended install
@@ -171,6 +172,7 @@ public async Task StartAsync(CancellationToken cancellationToken)
171172
break;
172173
}
173174

175+
// TODO (V10): Remove this obsoleted notification publish.
174176
await _eventAggregator.PublishAsync(new UmbracoApplicationComponentsInstallingNotification(State.Level), cancellationToken);
175177

176178
// create & initialize the components

0 commit comments

Comments
 (0)