Skip to content

Commit e668755

Browse files
authored
Listview: Fix translations and use "Remove" text for button instead of icon (#11411)
1 parent 9a16907 commit e668755

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed

src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/includeproperties.prevalues.html

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
<thead>
1919
<tr>
2020
<td></td>
21-
<th>Alias</th>
22-
<th>Header</th>
21+
<th><localize key="general_alias">Alias</localize></th>
22+
<th><localize key="general_header">Header</localize></th>
2323
<th><localize key="template_template">Template</localize></th>
2424
<td></td>
2525
</tr>
@@ -32,14 +32,16 @@
3232
<td>
3333
<div class="list-view-layout__name flex-column content-start">
3434
<span class="list-view-layout__name-text" ng-bind="val.alias"></span>
35-
<span class="list-view-layout__system" ng-show="val.isSystem == 1">(system field)</span>
35+
<span class="list-view-layout__system" ng-show="val.isSystem == 1">(<localize key="general_systemField">systemField</localize>)</span>
3636
</div>
3737
</td>
3838
<td>
3939
<ng-form name="headerForm" ng-if="!val.isSystem">
4040
<input type="text" name="header" ng-model="val.header" required />
4141
<span ng-messages="headerForm.header.$error" show-validation-on-submit>
42-
<span class="help-inline" ng-message="required">Required</span>
42+
<span class="help-inline" ng-message="required">
43+
<localize key="general_required">Required</localize>
44+
</span>
4345
</span>
4446
</ng-form>
4547

@@ -53,8 +55,8 @@
5355
</ng-form>
5456
</td>
5557
<td>
56-
<button type="button" class="btn-icon" ng-click="removeField(val)" aria-label="Remove">
57-
<umb-icon icon="icon-trash"></umb-icon>
58+
<button type="button" class="umb-node-preview__action umb-node-preview__action--red" ng-click="removeField(val)">
59+
<localize key="general_remove">Remove</localize><span class="sr-only"> {{val.alias}}</span>
5860
</button>
5961
</td>
6062
</tr>
@@ -63,5 +65,4 @@
6365
</table>
6466
</div>
6567

66-
67-
</div>
68+
</div>

src/Umbraco.Web.UI/Umbraco/config/lang/da.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -813,6 +813,8 @@
813813
<key alias="videos">Videoer</key>
814814
<key alias="installing">installere</key>
815815
<key alias="avatar">Avatar til</key>
816+
<key alias="header">Overskrift</key>
817+
<key alias="systemField">system felt</key>
816818
</area>
817819
<area alias="colors">
818820
<key alias="blue">Blå</key>

src/Umbraco.Web.UI/Umbraco/config/lang/en.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -802,6 +802,8 @@
802802
<key alias="videos">Videos</key>
803803
<key alias="installing">Installing</key>
804804
<key alias="avatar">Avatar for</key>
805+
<key alias="header">Header</key>
806+
<key alias="systemField">system field</key>
805807
</area>
806808
<area alias="colors">
807809
<key alias="blue">Blue</key>

src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -811,6 +811,8 @@
811811
<key alias="videos">Videos</key>
812812
<key alias="installing">Installing</key>
813813
<key alias="avatar">Avatar for</key>
814+
<key alias="header">Header</key>
815+
<key alias="systemField">system field</key>
814816
</area>
815817
<area alias="colors">
816818
<key alias="blue">Blue</key>

0 commit comments

Comments
 (0)