Skip to content

Commit fe396ba

Browse files
committed
Inverted conditional on linking user for clarity.
1 parent c6176a0 commit fe396ba

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/Umbraco.Web.BackOffice/Security/BackOfficeSignInManager.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -194,14 +194,14 @@ private async Task<SignInResult> AutoLinkAndSignInExternalAccount(ExternalLoginI
194194
}
195195

196196
var shouldLinkUser = autoLinkOptions.OnExternalLogin == null || autoLinkOptions.OnExternalLogin(autoLinkUser, loginInfo);
197-
if (shouldLinkUser == false)
197+
if (shouldLinkUser)
198198
{
199-
LogFailedExternalLogin(loginInfo, autoLinkUser);
200-
return ExternalLoginSignInResult.NotAllowed;
199+
return await LinkUser(autoLinkUser, loginInfo);
201200
}
202201
else
203202
{
204-
return await LinkUser(autoLinkUser, loginInfo);
203+
LogFailedExternalLogin(loginInfo, autoLinkUser);
204+
return ExternalLoginSignInResult.NotAllowed;
205205
}
206206
}
207207
else
@@ -236,14 +236,14 @@ private async Task<SignInResult> AutoLinkAndSignInExternalAccount(ExternalLoginI
236236
else
237237
{
238238
var shouldLinkUser = autoLinkOptions.OnExternalLogin == null || autoLinkOptions.OnExternalLogin(autoLinkUser, loginInfo);
239-
if (shouldLinkUser == false)
239+
if (shouldLinkUser)
240240
{
241-
LogFailedExternalLogin(loginInfo, autoLinkUser);
242-
return ExternalLoginSignInResult.NotAllowed;
241+
return await LinkUser(autoLinkUser, loginInfo);
243242
}
244243
else
245244
{
246-
return await LinkUser(autoLinkUser, loginInfo);
245+
LogFailedExternalLogin(loginInfo, autoLinkUser);
246+
return ExternalLoginSignInResult.NotAllowed;
247247
}
248248
}
249249
}

0 commit comments

Comments
 (0)