Backwards-compatible implementation of ToUrlSegment() #11173
JoseMarcenaro
started this conversation in
Features and ideas
Replies: 2 comments
-
PR #11174 submitted |
Beta Was this translation helpful? Give feedback.
0 replies
-
Ha - Was just about to complain loudly over this too — thanks for beating me to it 👍 😁 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Sometimes I have the impression that the DI dogma has been pushed a little bit too far in v9, making everyday tasks more complicated than what they should be.
An example of that is the v8 extension method
ToUrlSegment( IShortStringHelper shortStringHelper)
, in which the dependency injection version adds the flexibility of choosing the short string helper ... at the cost of forcing to do it every time and breaking the compatibility with v8 - even when in many cases the default implementation is Ok.Note that this utility method is frequently used inside extension methods / static helpers, so getting a handler to the DI helper is not trivial.
I will submit a PR adding a default value for the parameter which uses the default implementation.
Beta Was this translation helpful? Give feedback.
All reactions