SqlSyntaxExtensions should be an instance method to allow database specific overrides #21827
idseefeld
started this conversation in
Features and ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
The
SqlSyntaxExtensionsmethods should be instance methods like all the otherISqlSyntaxProvidermethods and not an extension method. As instance method the onlypublic virtual string GetFieldName<TDto>(...)method could be overridden. This would also improve code consistency.This change is not a breaking change. All references will work with an instance method too and to avoid breaking change issues, the
interfaceprovides a temporary implementation.ISqlSyntaxProviderhas already aToDo, that all implementations should be removed in v18.I have already a branch in my fork: refactor-SqlSytaxExtensions-to-instance-methods to implement this.
Beta Was this translation helpful? Give feedback.
All reactions