Content -> Page -> BlockGrid Property -> Add Block -> Search Input Not Working

[mlebretonFR]

Which Umbraco version are you using?

16.0.0-rc3

Bug summary

The search input is the add block dialog is not working.

Specifics

Steps to reproduce

• Create a Page ContentType with a BlockGrid content property.
• Setup the BlockGrid editor with some blocks.
• Move to the content section.
• Create a Page.
• Click to 'Add Content' on the content property.
• The block adding UI opens. It contains all the possible blocks.
• In the search input, try to search a block.
• It does not work.

Expected result / actual result

No response

---

This item has been added to our backlog AB#53441

[github-actions]

Hi there @mlebretonFR!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[lauraneto]

Hi @mlebretonFR ,

Thank you for raising this issue!

I was able to reproduce this in 16.0.0-rc3 and 15.4.1.
In block-catalogue-modal.element.ts#L87 block.label is not set, and therefore the filtering does not work.

Note: in order to reproduce this you need to add at least 9 blocks to the block grid, otherwise the search box does not appear.

Update: The issue is that you would expect it to search on the "name" of the block, but instead it is searching on the "label" you set for that block.

[mlebretonFR]

Good point. I hadn't paid attention to that. I foolishly assumed the search was done on the label (if specified) or on the name.

After checking : if the labels are defined, it works fine 😉. Thank you very much for this answer.

A small addition to the documentation would avoid this confusion.

Something like : umbraco/UmbracoDocs#7130

[lauraneto]

Hi @mlebretonFR ,

Sorry for the misunderstanding!
Those were more like notes for whoever picks this up in the future. I should be more clear next time, sorry. 😅

I do think that the search should be on name (or both name and label), because that is what you see in the UI so that is what one would expect. I also tested this in v13 and it was searching based on the name (I did not check if label also worked).

[AndyButland]

I had a look into this - unfortunately I haven't found a solution but can add a little more context. The issue here is that the blocks to pick from are rendered only from the configuration data stored for the block list data type. That means for each block the only thing we are guaranteed to have is the block's element type key. If a label - or any other settings like the background colour or icon colour - are provided they will be included too, but there's no guarantee that there are.

That's why the search works when labels are populated.

But when rendering the list of blocks, there's not necessarily a label to search on (and no name).

We could look-up the names of the blocks without labels from their IDs. populate the labels with this name, and then they would beavailable to search on. That should work. But we're already doing this in the umb-block-type-card component, so this would duplicate some requests which seems unnecessary.