SVG image previews in the media library sometimes extend outside the editor bounds

[argentini]

Which Umbraco version are you using?

16.1.1

Bug summary

SVG image previews in the media library sometimes extend outside the editor bounds.

Specifics

No response

Steps to reproduce

Create a media with the attached SVG and see that it extends past the editor bounds.

Expected result / actual result

No response

[github-actions]

Hi there @argentini!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[github-actions]

Hi @argentini,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

[leekelleher]

@argentini Thanks for reporting this. I see what you mean. 😕

The issue with the image/media card previews is how to apply generic styles across all image dimensions. We currently have the style rule of object-fit: cover; which will let the browser position the image centrally. I've tried some variations of different heights/widths, but then run into other issues with images that are narrow (height is bigger than width) or wide (width is bigger than height).

I've marked this as open for a community contribution, as it would be great to gauge a consensus on how the image/media card previews should be presented.

[argentini]

Hey @leekelleher it looks like deep into the shadow dom this SVG is just using an <img> tag. Adding max-width:100% seems to fix it without distorting the aspect ratio. I don't think the issue affects bitmap images. Just SVG's like this.

[argentini]

Hey @leekelleher to be clear I was talking about the image previews on the media item view, not the collection cards.

[leekelleher]

@argentini Ah okay, thank you for the clarification, I had misunderstood which type of media preview was the issue. 🤦

I agree with your suggestion of setting the inner <img> to have max-width: 100%. 💯

I'll keep this tagged with community/up-for-grabs, as I think it would make an excellent first-time contribution. 😁
(Link reference to the umb-input-upload-field-svg component)