-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Description
Which Umbraco version are you using?
17.0.0-rc1
Bug summary
When you create a package from within the package section of the Umbraco backoffice and you save and download it, the package.xml file doesn't include the the labels for the block list items.
They are present on the items in the original backoffice that the package was created from, but they don't get included when downloading the package.zip
Specifics
When you create a package from within the package section of the Umbraco backoffice and you save and download it, the package.xml file doesn't include the the labels for the block list items.
They are present on the items in the original backoffice that the package was created from
but they don't get included in the package.xml when you download it:
<DataType Name="[BlockList] Main Content" Id="Umbraco.BlockList" EditorUiAlias="Umb.PropertyEditorUi.BlockList" Definition="b5922818-d8d8-43df-88ed-4582a24c0fa6" DatabaseType="Ntext" Configuration="{"blocks":[{"contentElementTypeKey":"dd183f78-7d69-4eda-9b4c-a25970583a28","settingsElementTypeKey":"da15dc43-43f6-45f6-bda8-1fd17a49d25c"},{"contentElementTypeKey":"e0df4794-063a-4450-8f4f-c615a5d902e2","settingsElementTypeKey":"fed88ec5-c150-42af-b444-1f9ac5a100ba"},{"contentElementTypeKey":"f43c8349-0801-44b8-9113-9f7c62cd44fe","settingsElementTypeKey":"eef34ceb-ddf6-4894-b1ac-f96c8c05d3d2"},{"contentElementTypeKey":"f37c2c28-c8ab-48cd-ac07-b13e38bd900f","settingsElementTypeKey":"93638715-f76c-4a11-86b1-6a9d66504901"},{"contentElementTypeKey":"1c43fe2d-4a9a-4336-923f-9d0214950d48","settingsElementTypeKey":"378fde96-51b6-4506-93e3-ec3038e636bb"},{"contentElementTypeKey":"60085a63-b77b-4509-9df4-bcb75db2755f","settingsElementTypeKey":"c56fb5b8-0b89-4206-847e-a6fecd865b84"}],"validationLimit":{"min":null,"max":null},"useSingleBlockMode":false}" />Steps to reproduce
- Install umbraco 17.0.0-rc1 with clean 7.0.0-rc1 using this script
# Ensure we have the version specific Umbraco templates
dotnet new install Umbraco.Templates::17.0.0-rc1 --force
# Create solution/project
dotnet new sln --name "MySolution"
dotnet new umbraco --force -n "MyProject" --friendly-name "Administrator" --email "[email protected]" --password "1234567890" --development-database-type SQLite
dotnet sln add "MyProject"
#Add Packages
dotnet add "MyProject" package Clean --version 7.0.0-rc1
dotnet run --project "MyProject"
#Running-
Then log into the backoffice using
username: [email protected]
password: 1234567890 -
Go to the Packages section
-
Create a new package
-
Enter a name for the package
-
Select the
[BlockList] Main Contentdata type -
Click on create
-
Click on Download
-
Open the package.xml file in a text editor
-
See that the label has not been included in the DataType xml. (See the expected vs actual below)
Expected result / actual result
Expected xml for this data type
<DataType Name="[BlockList] Main Content" Id="Umbraco.BlockList" EditorUiAlias="Umb.PropertyEditorUi.BlockList" Definition="b5922818-d8d8-43df-88ed-4582a24c0fa6" DatabaseType="Ntext" Configuration="{"blocks":[{"contentElementTypeKey":"dd183f78-7d69-4eda-9b4c-a25970583a28","settingsElementTypeKey":"da15dc43-43f6-45f6-bda8-1fd17a49d25c","label":"Rich Text: ${ content.markup | stripHtml} ${$settings.hide == \u00271\u0027 ? \u0027[HIDDEN]\u0027 : \u0027\u0027}"},{"contentElementTypeKey":"e0df4794-063a-4450-8f4f-c615a5d902e2","settingsElementTypeKey":"fed88ec5-c150-42af-b444-1f9ac5a100ba","label":"Image: ${ caption } ${$settings.hide == \u00271\u0027 ? \u0027[HIDDEN]\u0027 : \u0027\u0027}"},{"contentElementTypeKey":"f43c8349-0801-44b8-9113-9f7c62cd44fe","settingsElementTypeKey":"eef34ceb-ddf6-4894-b1ac-f96c8c05d3d2","label":"Video: ${ caption != \u0027\u0027 ? caption : videoUrl } ${$settings.hide == \u00271\u0027 ? \u0027[HIDDEN]\u0027 : \u0027\u0027}"},{"contentElementTypeKey":"f37c2c28-c8ab-48cd-ac07-b13e38bd900f","settingsElementTypeKey":"93638715-f76c-4a11-86b1-6a9d66504901","label":"Code Snippet: ${ title } ${$settings.hide == \u00271\u0027 ? \u0027[HIDDEN]\u0027 : \u0027\u0027}"},{"contentElementTypeKey":"1c43fe2d-4a9a-4336-923f-9d0214950d48","settingsElementTypeKey":"378fde96-51b6-4506-93e3-ec3038e636bb","label":"Image Carousel: ${$settings.hide == \u00271\u0027 ? \u0027[HIDDEN]\u0027 : \u0027\u0027}"},{"contentElementTypeKey":"60085a63-b77b-4509-9df4-bcb75db2755f","settingsElementTypeKey":"c56fb5b8-0b89-4206-847e-a6fecd865b84","label":"{umbContentName:articleList} Articles ${$settings.hide == \u00271\u0027 ? \u0027[HIDDEN]\u0027 : \u0027\u0027}"}],"validationLimit":{"min":null,"max":null},"useSingleBlockMode":false}" />Actual:
<DataType Name="[BlockList] Main Content" Id="Umbraco.BlockList" EditorUiAlias="Umb.PropertyEditorUi.BlockList" Definition="b5922818-d8d8-43df-88ed-4582a24c0fa6" DatabaseType="Ntext" Configuration="{"blocks":[{"contentElementTypeKey":"dd183f78-7d69-4eda-9b4c-a25970583a28","settingsElementTypeKey":"da15dc43-43f6-45f6-bda8-1fd17a49d25c"},{"contentElementTypeKey":"e0df4794-063a-4450-8f4f-c615a5d902e2","settingsElementTypeKey":"fed88ec5-c150-42af-b444-1f9ac5a100ba"},{"contentElementTypeKey":"f43c8349-0801-44b8-9113-9f7c62cd44fe","settingsElementTypeKey":"eef34ceb-ddf6-4894-b1ac-f96c8c05d3d2"},{"contentElementTypeKey":"f37c2c28-c8ab-48cd-ac07-b13e38bd900f","settingsElementTypeKey":"93638715-f76c-4a11-86b1-6a9d66504901"},{"contentElementTypeKey":"1c43fe2d-4a9a-4336-923f-9d0214950d48","settingsElementTypeKey":"378fde96-51b6-4506-93e3-ec3038e636bb"},{"contentElementTypeKey":"60085a63-b77b-4509-9df4-bcb75db2755f","settingsElementTypeKey":"c56fb5b8-0b89-4206-847e-a6fecd865b84"}],"validationLimit":{"min":null,"max":null},"useSingleBlockMode":false}" />This item has been added to our backlog AB#62036