Switch workspace variant when app language changes #19288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the document workspace editor to switch the workspace variant dynamically when the app language changes.
- Added logic to obtain the active segment from the split view.
- Created a new variant ID based on the new app language and active segment, and switched the variant accordingly.
...eb.UI.Client/src/packages/documents/documents/workspace/document-workspace-editor.element.ts
Outdated
Show resolved
Hide resolved
| @@ -32,6 +33,11 @@ export class UmbDocumentWorkspaceEditorElement extends UmbLitElement { | |||
| this.observe(this.#appLanguage?.appLanguageCulture, (appCulture) => { | |||
| this.#appCulture = appCulture; | |||
| this.#generateRoutes(); | |||
| // If the global app language changes, we update the first split view editor to the new app language. | |||
There was a problem hiding this comment.
Would it make sense to only update if the left side panel was the old App Language?
Or update all splitViews that had the same Culture as the old?
Cause what if I ended up having it in reversed order?
And what if I was working with segments and wanted to change culture?
|
Closing this PR as the solution has changed after we introduced a Variant Context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16853