Property Editors: Added form control and mandatory support(User, Member, Member Group) #20672
+143
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removed super.value.
| } | ||
|
|
||
| override render() { | ||
| console.log(this.value); |
Member
There was a problem hiding this comment.
Ups, this should be removed :-)
Member
There was a problem hiding this comment.
Aslo there is some merge conflicts now, would be nice to get those resolved. let me know when this is resolved and I will approve it :-)
Contributor
Author
There was a problem hiding this comment.
Console.log removed and merging conflicts are solved. :)
…://github.com/umbraco/Umbraco-CMS into v17/improvement/property-editors-people-group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update some Property Editors to align with the FormControl validation pattern.
Changes