Member types: Prepare container support #20715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ad213a2.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables container (folder) support for Member Types in Umbraco CMS. Previously, the MemberTypeContainerRepository was a no-op implementation that returned empty results, preventing the organization of member types into folders. This change replaces it with a full implementation that inherits from EntityContainerRepository, bringing member types in line with content types, media types, and data types.
- Replaced no-op
MemberTypeContainerRepositorywith functional implementation extendingEntityContainerRepository - Added
MemberTypeContainerto allowed container types inEntityContainerRepository - Registered
MemberTypetoMemberTypeContainermapping inEntityContainermodel
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberTypeContainerRepository.cs | Replaced no-op implementation with functional repository extending EntityContainerRepository |
| src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityContainerRepository.cs | Added MemberTypeContainer to the list of allowed container types |
| src/Umbraco.Core/Models/EntityContainer.cs | Added MemberType to MemberTypeContainer mapping in ObjectTypeMap dictionary |
ronaldbarendse
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the minimum necessary to allow Deploy to prepare support for member type containers, expected in 17.1.
The intention is that it will work at a service level, but not be supported yet via the management API or the backoffice.
See #20706 for more details.