Continue work of this PR #20768
Draft
Continue work of this PR #20768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the name() method in the content detail workspace context by adding a consistent fallback behavior for when no variant ID is provided.
- The
name()method now defaults to the invariant variant when novariantIdis specified, aligning it with the behavior ofsetName()andsetPropertyValue()methods - Removes optional chaining on
variantId.compare()since the variable is now guaranteed to be defined
auto-merge was automatically disabled
November 10, 2025 12:02
Pull request was converted to draft
nielslyngsoe
added
state/sprint-candidate
azure-devops-sync
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fix I(Niels) did here is not the right solution #20759
The `name` observer, the result of the method, should get the name of the first active variant. Making it reactive to the active variant, meaning variant-ID cannot be resolved in the method, but as part of the observable.
As well getName, should get the active (most left) variant and gives the name of that.
There might be an architectural challenge in this as the awareness of active variants is located in the Split View Context. — Please avoid spaghetti relations between these, maybe it not posible to make it happen without a mess, then we should back out and look for other sensible solutions.