Skip to content

Conversation

@nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Nov 11, 2025

Stop updating on input, as it gives annoying experience when having name conflicts with other tabs.

This also aligns with how Group Name works.

Copilot AI review requested due to automatic review settings November 11, 2025 11:34
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) November 11, 2025 11:34
Copilot finished reviewing on behalf of nielslyngsoe November 11, 2025 11:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the user experience when editing tab names in the Content Type Designer by preventing automatic name conflict resolution from triggering on every keystroke.

Key Changes:

  • Removed the @input event handler from tab name input fields, keeping only @change and @blur handlers
  • Tab names now update only when the user finishes editing (blur or Enter key), not during typing

Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants