Skip to content

Data Type Workspace: Enable client mandatory field validation for configuration properties #20799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

Data Type Workspace: Enable client mandatory field validation for configuration properties #20799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef69f16
Add validation property to PropertyEditorSettingsProperty
madsrasmussen Nov 12, 2025
bbf04ee
Pass validation property to umb-property component
madsrasmussen Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...o.Web.UI.Client/src/packages/core/property-editor/extensions/property-editor.extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ export interface PropertyEditorSettingsProperty {
propertyEditorDataSourceAlias?: string;
config?: UmbPropertyEditorConfig;
weight?: number;
validation?: {
mandatory: boolean;
mandatoryMessage?: string | null;
};
Comment on lines +72 to +75
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation property in PropertyEditorSettingsProperty has an incomplete type definition. It should extend UmbPropertyTypeValidationModel to include the optional regEx and regExMessage properties for consistency with the validation model used throughout the codebase.

Current definition:

validation?: {
    mandatory: boolean;
    mandatoryMessage?: string | null;
};

Should be:

validation?: {
    mandatory: boolean;
    mandatoryMessage?: string | null;
    regEx?: string | null;
    regExMessage?: string | null;
};

Or better yet, import and use the existing type:

validation?: UmbPropertyTypeValidationModel;

This ensures type compatibility when passing property.validation to the umb-property element which expects UmbPropertyTypeValidationModel.

Copilot uses AI. Check for mistakes.
}

// eslint-disable-next-line @typescript-eslint/naming-convention
Expand Down
3 changes: 2 additions & 1 deletion ...rc/packages/data-type/components/property-editor-config/property-editor-config.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ export class UmbPropertyEditorConfigElement extends UmbLitElement {
alias=${property.alias}
property-editor-ui-alias=${property.propertyEditorUiAlias}
property-editor-data-source-alias=${ifDefined(property.propertyEditorDataSourceAlias)}
.config=${property.config}></umb-property>`,
.config=${property.config}
.validation=${property.validation}></umb-property>`,
)
: html`<umb-localize key="editdatatype_noConfiguration"
>There is no configuration for this property editor.</umb-localize
Expand Down
Loading