Content picker: Allow selections on a content picker on a read-only document to be opened (closes #20816) #20819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyButland
changed the title
Copilot finished reviewing on behalf of
AndyButland
November 13, 2025 10:47
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables users with read-only or browse-only permissions to open content picker selections for viewing. Previously, the "Open" button was hidden when a document was read-only, preventing users from viewing the selected content even though they had permission to browse it.
Key Changes:
- Removes the
readonlycheck from theallow-opencondition in the content picker template, allowing the "Open" button to appear based solely on configuration and user section access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes: #20816
Description
There's no reason a user with only permissions to browse a node shouldn't be able to open the selections on a content picker, so this update allows it.
Testing
With a user that only has "Browse" permissions for a document that has a content picker on it, verify that the "Open" button is available next to the selected items.