Culture and Hostnames: Add ability to sort hostnames (closes #20691) #20826
+176
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able to drag the hostname elements around to sort them
… look better. Added a description for the Culture section. Alligned the rendered text to allign better with the name "Culture and Hostnames"
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restores the ability to drag-and-drop reorder Culture and Hostnames entries (previously available in v13) by implementing the UmbSorterController. It also updates UI terminology from "domain/domains" to "hostname/hostnames" for better alignment with the feature name "Culture and Hostnames".
Key Changes:
- Implemented
UmbSorterControllerfor drag-and-drop sorting of hostname entries - Extended the backend's
DomainPresentationModelwith a localUmbDomainPresentationModelinterface that includes auniqueproperty for tracking items during sorting - Updated all UI strings from "domain" to "hostname" terminology across the English language file
- Refactored the modal layout to use
umb-property-layoutcomponents for consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/culture-and-hostnames/modal/culture-and-hostnames-modal.element.ts |
Implements UmbSorterController for drag-and-drop functionality, adds unique ID tracking for hostname items, refactors render methods to support sorting with visual feedback |
src/Umbraco.Web.UI.Client/src/assets/lang/en.ts |
Updates all UI terminology from "domain/domains" to "hostname/hostnames" for consistency with the "Culture and Hostnames" feature naming |
.../documents/entity-actions/culture-and-hostnames/modal/culture-and-hostnames-modal.element.ts
Outdated
Show resolved
Hide resolved
.../documents/entity-actions/culture-and-hostnames/modal/culture-and-hostnames-modal.element.ts
Outdated
Show resolved
Hide resolved
.../documents/entity-actions/culture-and-hostnames/modal/culture-and-hostnames-modal.element.ts
Outdated
Show resolved
Hide resolved
…ity-actions/culture-and-hostnames/modal/culture-and-hostnames-modal.element.ts Forgot to remove this after I was done testing Co-authored-by: Copilot <[email protected]>
…ity-actions/culture-and-hostnames/modal/culture-and-hostnames-modal.element.ts Changing grid-gap to just gap Co-authored-by: Copilot <[email protected]>
…eded. Removed the conditional rendering that was attached to the readonly and disabled properties
madsrasmussen
changed the title
madsrasmussen
requested changes
Nov 14, 2025
Contributor
madsrasmussen
left a comment
madsrasmussen
left a comment
There was a problem hiding this comment.
Great! The changes look good, only a few comments, and the feature works as expected.
.../documents/entity-actions/culture-and-hostnames/modal/culture-and-hostnames-modal.element.ts
Outdated
Show resolved
Hide resolved
.../documents/entity-actions/culture-and-hostnames/modal/culture-and-hostnames-modal.element.ts
Outdated
Show resolved
Hide resolved
.../documents/entity-actions/culture-and-hostnames/modal/culture-and-hostnames-modal.element.ts
Outdated
Show resolved
Hide resolved
… to target the hostname-item class instead
madsrasmussen
approved these changes
Nov 14, 2025
Contributor
|
I expect you've seen, but in case not, looks like this has caused a failing test - likely as the test was relying on some UI that's changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20691
Added the sorter controller and implemented it for the hostname/domain elements.
You are now able to drag the hostname elements around to sort them like in v13.
There has also been some cleanup in the HTML to make it more concise.
Changed the naming shown in UI to align better with the naming "Culture and Hostnames"
Instead of it being called domain/domains, it is now referred to as hostname/hostnames.