Skip to content

Removes npm commands from MSBuild of the CSPROJ for umbraco-extension dotnet new template #20839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: release/17.0
Choose a base branch
from
+0 −17
Open

Removes npm commands from MSBuild of the CSPROJ for umbraco-extension dotnet new template #20839

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9a312f
Removes npm commands from the MSBuild of the CSPROJ of the umbraco-ex…
warrenbuckley Nov 14, 2025
e4c98cf
Merge branch 'release/17.0' into package-team/remove-csproj-from-exte…
warrenbuckley Nov 14, 2025
0a5005e
Removed the unused value - good catch by Copilot
warrenbuckley Nov 14, 2025
35576fa
Merge branch 'package-team/remove-csproj-from-extension' of https://g…
warrenbuckley Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions templates/UmbracoExtension/Umbraco.Extension.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
</ItemGroup>

<ItemGroup>
<ClientAssetsInputs Include="Client\**" Exclude="$(DefaultItemExcludes)" />

<!-- Dont include the client folder as part of packaging nuget build -->
<Content Remove="Client\**" />

Expand All @@ -39,19 +37,4 @@
<Folder Include="wwwroot\" />
</ItemGroup>

<!-- Restore and build Client files -->
<Target Name="RestoreClient" Inputs="Client\package.json;Client\package-lock.json" Outputs="Client\node_modules\.package-lock.json">
<Message Importance="high" Text="Restoring Client NPM packages..." />
<Exec Command="npm i" WorkingDirectory="Client" />
</Target>

<Target Name="BuildClient" BeforeTargets="AssignTargetPaths" DependsOnTargets="RestoreClient" Inputs="@(ClientAssetsInputs)" Outputs="$(IntermediateOutputPath)client.complete.txt">
<Message Importance="high" Text="Executing Client NPM build script..." />
<Exec Command="npm run build" WorkingDirectory="Client" />
<ItemGroup>
<_ClientAssetsBuildOutput Include="wwwroot\App_Plugins\**" />
</ItemGroup>
<WriteLinesToFile File="$(IntermediateOutputPath)client.complete.txt" Lines="@(_ClientAssetsBuildOutput)" Overwrite="true" />
</Target>

</Project>
Loading