Skip to content

Commit 07a4248

Browse files
loivseniOvergaard
authored andcommitted
sonar issues
1 parent 013683f commit 07a4248

File tree

6 files changed

+12
-13
lines changed

6 files changed

+12
-13
lines changed

src/packages/media/media/components/input-upload-field/input-upload-field.element.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ export class UmbInputUploadFieldElement extends UmbLitElement {
208208
this.dispatchEvent(new UmbChangeEvent());
209209
}
210210

211-
static override styles = [
211+
static override readonly styles = [
212212
css`
213213
:host {
214214
position: relative;

src/packages/media/media/components/input-upload-field/preview/input-upload-field-audio.element.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default class UmbInputUploadFieldAudioElement extends UmbLitElement {
1212
return html`<audio controls src=${this.path}></audio>`;
1313
}
1414

15-
static override styles = [
15+
static override readonly styles = [
1616
css`
1717
:host {
1818
display: flex;

src/packages/media/media/components/input-upload-field/preview/input-upload-field-file.element.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,21 +45,20 @@ export default class UmbInputUploadFieldFileElement extends UmbLitElement {
4545
if (this.#serverUrl) {
4646
if (this.file) return;
4747

48-
this.extension = this.path.split('.').pop() || '';
48+
this.extension = this.path.split('.').pop() ?? '';
4949
this.label = this.#serverUrl ? this.path.substring(this.#serverUrl.length) : 'loading...';
5050
}
5151
}
5252
}
5353

5454
#getExtensionFromMime(mime: string): string {
55-
//TODO Temporary solution.
5655
if (!mime) return ''; //folders
56+
5757
const extension = mime.split('/')[1];
58-
switch (extension) {
59-
case 'svg+xml':
60-
return 'svg';
61-
default:
62-
return extension;
58+
if (extension === 'svg+xml') {
59+
return 'svg';
60+
} else {
61+
return extension;
6362
}
6463
}
6564

@@ -83,7 +82,7 @@ export default class UmbInputUploadFieldFileElement extends UmbLitElement {
8382
`;
8483
}
8584

86-
static override styles = [
85+
static override readonly styles = [
8786
css`
8887
#main {
8988
display: grid;

src/packages/media/media/components/input-upload-field/preview/input-upload-field-image.element.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default class UmbInputUploadFieldImageElement extends UmbLitElement {
1212
return html`<img src=${this.path} alt="" />`;
1313
}
1414

15-
static override styles = [
15+
static override readonly styles = [
1616
css`
1717
:host {
1818
display: flex;

src/packages/media/media/components/input-upload-field/preview/input-upload-field-svg.element.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default class UmbInputUploadFieldSvgElement extends UmbLitElement {
1212
return html`<img src=${this.path} alt="svg" />`;
1313
}
1414

15-
static override styles = [
15+
static override readonly styles = [
1616
css`
1717
:host {
1818
display: flex;

src/packages/media/media/components/input-upload-field/preview/input-upload-field-video.element.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export default class UmbInputUploadFieldVideoElement extends UmbLitElement {
1717
`;
1818
}
1919

20-
static override styles = [
20+
static override readonly styles = [
2121
css`
2222
:host {
2323
display: flex;

0 commit comments

Comments
 (0)