Skip to content

Commit 227ff1f

Browse files
committed
fix: add fixes for eslint errors particularly around unused vars and wrongful null-coalescing checks for Number() and Boolean()
1 parent f31402e commit 227ff1f

File tree

27 files changed

+27
-101
lines changed

27 files changed

+27
-101
lines changed

src/mocks/data/template/template-query.manager.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
1-
import type { UmbEntityMockDbBase } from '../utils/entity/entity-base.js';
21
import { templateQueryResult, templateQuerySettings, type UmbMockTemplateModel } from './template.data.js';
32

43
export class UmbMockTemplateQueryManager {
5-
#db: UmbEntityMockDbBase<UmbMockTemplateModel>;
6-
7-
constructor(db: UmbEntityMockDbBase<UmbMockTemplateModel>) {
8-
this.#db = db;
9-
}
4+
constructor() {}
105

116
getQuerySettings = () => templateQuerySettings;
127

src/mocks/data/template/template.db.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class UmbTemplateMockDB extends UmbEntityMockDbBase<UmbMockTemplateModel> {
1414
tree = new UmbMockEntityTreeManager<UmbMockTemplateModel>(this, treeItemMapper);
1515
item = new UmbMockEntityItemManager<UmbMockTemplateModel>(this, itemMapper);
1616
detail = new UmbMockTemplateDetailManager(this);
17-
query = new UmbMockTemplateQueryManager(this);
17+
query = new UmbMockTemplateQueryManager();
1818

1919
constructor(data: Array<UmbMockTemplateModel>) {
2020
super(data);

src/packages/block/block-grid/components/block-grid-entries/block-grid-entries.element.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ export class UmbBlockGridEntriesElement extends UmbFormControlMixin(UmbLitElemen
132132
});
133133

134134
#context = new UmbBlockGridEntriesContext(this);
135-
#controlValidator: UmbFormControlValidator;
136135

137136
@property({ attribute: false })
138137
public set areaKey(value: string | null | undefined) {

src/packages/core/content-type/modals/property-type-settings/property-type-settings-modal.element.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ export class UmbPropertyTypeSettingsModalElement extends UmbModalBaseElement<
5252
/** Indicates if the currently edited property is a new property or an existing */
5353
#isNew = false;
5454

55-
#context = new UmbPropertyTypeWorkspaceContext(this);
56-
5755
@state()
5856
private _contentTypeVariesByCulture?: boolean;
5957

src/packages/core/content-type/structure/content-type-container-structure-helper.class.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ export class UmbContentTypeContainerStructureHelper<T extends UmbContentTypeMode
182182
}
183183

184184
#observeRootContainers() {
185-
if (!this.#structure || !this.#childType || !this.#containerId === undefined) return;
185+
if (!this.#structure || !this.#childType || this.#containerId === undefined) return;
186186

187187
this.observe(
188188
this.#structure.rootContainers(this.#childType),

src/packages/core/property-action/components/property-action-menu/property-action-menu.element.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ function ExtensionApiArgsMethod(manifest: ManifestPropertyAction): [UmbPropertyA
1717

1818
@customElement('umb-property-action-menu')
1919
export class UmbPropertyActionMenuElement extends UmbLitElement {
20-
#actionsInitializer?: UmbExtensionsElementAndApiInitializer<ManifestTypes, 'propertyAction'>;
21-
2220
@state()
2321
private _actions: Array<UmbExtensionElementAndApiInitializer<ManifestPropertyAction, never>> = [];
2422

@@ -27,7 +25,7 @@ export class UmbPropertyActionMenuElement extends UmbLitElement {
2725
this.#propertyEditorUiAlias = alias;
2826

2927
// TODO: Stop using string for 'propertyAction', we need to start using Const. [NL]
30-
this.#actionsInitializer = new UmbExtensionsElementAndApiInitializer(
28+
new UmbExtensionsElementAndApiInitializer(
3129
this,
3230
umbExtensionsRegistry,
3331
'propertyAction',

src/packages/core/router/route.context.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ const EmptyDiv = document.createElement('div');
1212
type UmbRoutePlusModalKey = UmbRoute & { __modalKey: string };
1313

1414
export class UmbRouteContext extends UmbContextBase<UmbRouteContext> {
15-
#mainRouter: IRouterSlot;
1615
#modalRouter: IRouterSlot;
1716
#modalRegistrations: UmbModalRouteRegistration[] = [];
1817
#modalContext?: typeof UMB_MODAL_MANAGER_CONTEXT.TYPE;
@@ -23,7 +22,6 @@ export class UmbRouteContext extends UmbContextBase<UmbRouteContext> {
2322

2423
constructor(host: UmbControllerHost, mainRouter: IRouterSlot, modalRouter: IRouterSlot) {
2524
super(host, UMB_ROUTE_CONTEXT);
26-
this.#mainRouter = mainRouter;
2725
this.#modalRouter = modalRouter;
2826
this.consumeContext(UMB_MODAL_MANAGER_CONTEXT, (context) => {
2927
this.#modalContext = context;

src/packages/core/section/section-sidebar/section-sidebar.element.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
1-
import { UmbSectionSidebarContext } from './section-sidebar.context.js';
21
import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
32
import { css, html, customElement } from '@umbraco-cms/backoffice/external/lit';
43
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
54

65
@customElement('umb-section-sidebar')
76
export class UmbSectionSidebarElement extends UmbLitElement {
8-
#sectionSidebarContext = new UmbSectionSidebarContext(this);
9-
107
override render() {
118
return html`
129
<umb-section-sidebar-context-menu>

src/packages/core/tree/entity-actions/sort-children-of/modal/sort-children-of-modal.element.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export class UmbSortChildrenOfModalElement extends UmbModalBaseElement<
5151
}
5252

5353
async #requestChildren() {
54-
if (!this.data?.unique === undefined) throw new Error('unique is required');
54+
if (this.data?.unique === undefined) throw new Error('unique is required');
5555
if (!this.data?.treeRepositoryAlias) throw new Error('treeRepositoryAlias is required');
5656

5757
const treeRepository = await createExtensionApiByAlias<UmbTreeRepository<UmbTreeItemModel>>(

src/packages/core/workspace/components/workspace-collection/workspace-view-collection.element.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,14 @@ export class UmbWorkspaceViewCollectionElement extends UmbLitElement implements
6060

6161
#mapDataTypeConfigToCollectionConfig(dataType: UmbDataTypeDetailModel): UmbCollectionConfiguration {
6262
const config = new UmbPropertyEditorConfigCollection(dataType.values);
63+
const pageSize = Number(config.getValueByAlias('pageSize'));
6364
return {
6465
unique: this._documentUnique,
6566
allowedEntityBulkActions: config?.getValueByAlias<UmbCollectionBulkActionPermissions>('bulkActionPermissions'),
6667
layouts: config?.getValueByAlias('layouts'),
6768
orderBy: config?.getValueByAlias('orderBy') ?? 'updateDate',
6869
orderDirection: config?.getValueByAlias('orderDirection') ?? 'asc',
69-
pageSize: Number(config?.getValueByAlias('pageSize')) ?? 50,
70+
pageSize: isNaN(pageSize) ? 50 : pageSize,
7071
userDefinedProperties: config?.getValueByAlias('includeProperties'),
7172
};
7273
}

0 commit comments

Comments
 (0)