Skip to content

Commit 2d6e4a5

Browse files
authored
Merge pull request #2185 from umbraco/v14.2/hotfix/temp-location-for-manifest-viewer
Chore: temp solution: move manifest viewer files to the blocks package
2 parents 13d7c4e + a69fd2e commit 2d6e4a5

File tree

8 files changed

+6
-8
lines changed

8 files changed

+6
-8
lines changed

src/packages/block/block-type/components/block-type-custom-view-guide/block-type-custom-view-guide.element.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
1+
import { UMB_MANIFEST_VIEWER_MODAL } from '../../../modals/manifest-viewer/index.js';
12
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
23
import { html, customElement, state, property, css } from '@umbraco-cms/backoffice/external/lit';
34
import { UMB_PROPERTY_DATASET_CONTEXT } from '@umbraco-cms/backoffice/property';
4-
import {
5-
UMB_MANIFEST_VIEWER_MODAL,
6-
umbExtensionsRegistry,
7-
type ManifestBlockEditorCustomView,
8-
} from '@umbraco-cms/backoffice/extension-registry';
5+
import { umbExtensionsRegistry, type ManifestBlockEditorCustomView } from '@umbraco-cms/backoffice/extension-registry';
96
import { stringOrStringArrayContains } from '@umbraco-cms/backoffice/utils';
107
import { UmbExtensionsManifestInitializer } from '@umbraco-cms/backoffice/extension-api';
118
import { UmbDocumentTypeDetailRepository } from '@umbraco-cms/backoffice/document-type';

src/packages/block/manifests.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { manifests as blockGridManifests } from './block-grid/manifests.js';
33
import { manifests as blockListManifests } from './block-list/manifests.js';
44
import { manifests as blockRteManifests } from './block-rte/manifests.js';
55
import { manifests as blockTypeManifests } from './block-type/manifests.js';
6+
import { manifest as modalManifest } from './modals/manifest-viewer/manifest.js';
67
import type { ManifestTypes } from '@umbraco-cms/backoffice/extension-registry';
78
// TODO: Remove test custom view, or transfer to test or similar?
89
//import { manifest } from './custom-view/manifest.js';
@@ -14,4 +15,5 @@ export const manifests: Array<ManifestTypes> = [
1415
...blockListManifests,
1516
...blockGridManifests,
1617
...blockRteManifests,
18+
modalManifest,
1719
];
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ export interface UmbManifestViewerModalData extends ManifestBase {}
55

66
export type UmbManifestViewerModalValue = undefined;
77

8+
/* TODO: This is a temporary location for the manifest viewer files.They are located here because of build issues.
9+
Please don't export this token from the block package. [MR] */
810
export const UMB_MANIFEST_VIEWER_MODAL = new UmbModalToken<UmbManifestViewerModalData, UmbManifestViewerModalValue>(
911
'Umb.Modal.ManifestViewer',
1012
{

src/packages/core/extension-registry/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
export * from './conditions/index.js';
22
export * from './initializers/index.js';
3-
export * from './modals/manifest-viewer/index.js';
43
export * from './registry.js';
54
export * from './utils/index.js';
65
export type * from './interfaces/index.js';

src/packages/core/extension-registry/manifests.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { manifests as menuItemManifests } from './menu-item/manifests.js';
33
import { manifests as workspaceManifests } from './workspace/manifests.js';
44
import { manifests as collectionManifests } from './collection/manifests.js';
55
import { manifests as entityActionManifests } from './entity-actions/manifests.js';
6-
import { manifest as modalManifest } from './modals/manifest-viewer/manifest.js';
76
import type { ManifestTypes } from './models/index.js';
87

98
export const manifests: Array<ManifestTypes> = [
@@ -12,5 +11,4 @@ export const manifests: Array<ManifestTypes> = [
1211
...workspaceManifests,
1312
...collectionManifests,
1413
...entityActionManifests,
15-
modalManifest,
1614
];

0 commit comments

Comments
 (0)