Skip to content

Commit 4394b28

Browse files
committed
Merge branch 'main' into v14/chore/bundle-templating-package
2 parents 3983930 + f562985 commit 4394b28

File tree

8 files changed

+54
-87
lines changed

8 files changed

+54
-87
lines changed

.github/README.md

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@ The development environment is the default environment and is used when running
2929

3030
### Run against a local Umbraco instance
3131

32-
> **Note**
33-
> Make sure you have followed the [Authentication guide](https://github.com/umbraco/Umbraco.CMS.Backoffice/blob/main/docs/authentication.md) before continuing.
34-
3532
If you have a local Umbraco instance running, you can use the development environment to run against it by overriding the API URL and bypassing the mock-service-worker in the frontend client.
3633

3734
Create a `.env.local` file and set the following variables:
@@ -41,14 +38,37 @@ VITE_UMBRACO_API_URL=https://localhost:44339 # This will be the URL to your Umbr
4138
VITE_UMBRACO_USE_MSW=off # Indicate that you want all API calls to bypass MSW (mock-service-worker)
4239
```
4340

41+
Open this file in an editor: `src/Umbraco.Web.UI/appsettings.Development.json` and add this to the `Umbraco:CMS:Security` section to override the backoffice host:
42+
43+
```json
44+
"Umbraco": {
45+
"CMS": {
46+
"Security":{
47+
"BackOfficeHost": "http://localhost:5173",
48+
"AuthorizeCallbackPathName": "/oauth_complete",
49+
"AuthorizeCallbackLogoutPathName": "/logout",
50+
"AuthorizeCallbackErrorPathName": "/error",
51+
},
52+
},
53+
}
54+
```
55+
56+
Now start the vite server: `npm run dev:server` in your backoffice folder and open the http://localhost:5173 URL in your browser.
57+
4458
### Storybook
4559

4660
Storybook is also being built and deployed automatically on the Main branch, including a preview URL on each pull request. See it in action on this [Azure Static Web App](https://ambitious-stone-0033b3603.1.azurestaticapps.net/).
4761

62+
You can test the Storybook locally by running `npm run storybook`. This will start the Storybook server and open a browser window with the Storybook UI.
63+
64+
Storybook is an excellent tool to test out UI components in isolation and to document them. It is also a great way to test the responsiveness and accessibility of the components.
65+
4866
## Contributing
4967

50-
We accept contributions to this project. However be aware that we are mainly working on a private backlog, so not everyone will be immediately obvious. If you want to get started on contributing, please read the [contribute space](https://github.com/umbraco/Umbraco.CMS.Backoffice/contribute) where you will be able to find the guidelines on how to contribute as well as a list of good first issues.
68+
We accept contributions to this project. However be aware that we are mainly working on a private backlog, so not everything will be immediately obvious. If you want to get started on contributing, please read the [contributing guidelines](./CONTRIBUTING.md).
69+
70+
A list of issues can be found on the [Umbraco-CMS Issue Tracker](https://github.com/umbraco/Umbraco-CMS/issues). Many of them are marked as `community/up-for-grabs` which means they are up for grabs for anyone to work on.
5171

5272
## Documentation
5373

54-
The documentation can be found on [Umbraco Docs](https://docs.umbraco.com/umbraco-backoffice/). The documentation is a work in progress.
74+
The documentation can be found on [Umbraco Docs](https://docs.umbraco.com/umbraco-cms).

docs/authentication.md

Lines changed: 0 additions & 66 deletions
This file was deleted.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@
119119
"type": "git"
120120
},
121121
"bugs": {
122-
"url": "https://github.com/umbraco/Umbraco.CMS.Backoffice/issues"
122+
"url": "https://github.com/umbraco/Umbraco-CMS/issues"
123123
},
124124
"author": {
125125
"name": "Umbraco A/S",

src/assets/lang/da-dk.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1587,7 +1587,7 @@ export default {
15871587
requiredLabel: 'Påkrævet label',
15881588
enableListViewHeading: 'Aktivér listevisning',
15891589
enableListViewDescription:
1590-
'Konfigurér indholdet til at blive vist i en sortérbar og søgbar liste;\n undersider vil ikke blive vist i træet\n ',
1590+
'Konfigurér indholdet til at blive vist i en sortérbar og søgbar liste.',
15911591
allowedTemplatesHeading: 'Tilladte skabeloner',
15921592
allowedTemplatesDescription: 'Vælg hvilke skabeloner, der er tilladt at bruge på dette indhold.',
15931593
allowAtRootHeading: 'Tillad på rodniveau',
@@ -1682,7 +1682,7 @@ export default {
16821682
'Changing a data type with stored values is disabled. To allow this you can change the Umbraco:CMS:DataTypes:CanBeChanged setting in appsettings.json.',
16831683
collections: 'Samlinger',
16841684
collectionsDescription:
1685-
'Konfigurerer indholdselementet til at vise listen over dets underordnede elementer, underordnede elementer vil ikke blive vist i træet.',
1685+
'Konfigurerer indholdselementet til at vise listen over dets underordnede elementer.',
16861686
structure: 'Struktur',
16871687
presentation: 'Præsentation',
16881688
},

src/assets/lang/en-us.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1601,7 +1601,7 @@ export default {
16011601
requiredLabel: 'Required label',
16021602
enableListViewHeading: 'Enable list view',
16031603
enableListViewDescription:
1604-
'Configures the content item to show a sortable and searchable list of its\n children, the children will not be shown in the tree\n ',
1604+
'Configures the content item to show a sortable and searchable list of its children.',
16051605
allowedTemplatesHeading: 'Allowed Templates',
16061606
allowedTemplatesDescription: 'Choose which templates editors are allowed to use on content of this type',
16071607
allowAtRootHeading: 'Allow at root',
@@ -1694,7 +1694,7 @@ export default {
16941694
'Changing a data type with stored values is disabled. To allow this you can change the Umbraco:CMS:DataTypes:CanBeChanged setting in appsettings.json.',
16951695
collections: 'Collections',
16961696
collectionsDescription:
1697-
'Configures the content item to show list of its children, the children will not be shown in the tree.',
1697+
'Configures the content item to show list of its children.',
16981698
structure: 'Structure',
16991699
presentation: 'Presentation',
17001700
},

src/assets/lang/en.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1624,7 +1624,7 @@ export default {
16241624
requiredLabel: 'Required label',
16251625
enableListViewHeading: 'Enable list view',
16261626
enableListViewDescription:
1627-
'Configures the content item to show a sortable and searchable list of its\n children, the children will not be shown in the tree\n ',
1627+
'Configures the content item to show a sortable and searchable list of its children.',
16281628
allowedTemplatesHeading: 'Allowed Templates',
16291629
allowedTemplatesDescription: 'Choose which templates editors are allowed to use on content of this type',
16301630
allowAtRootHeading: 'Allow at root',
@@ -1718,7 +1718,7 @@ export default {
17181718
'Changing a data type with stored values is disabled. To allow this you can change the Umbraco:CMS:DataTypes:CanBeChanged setting in appsettings.json.',
17191719
collections: 'Collections',
17201720
collectionsDescription:
1721-
'Configures the content item to show list of its children, the children will not be shown in the tree.',
1721+
'Configures the content item to show list of its children.',
17221722
structure: 'Structure',
17231723
presentation: 'Presentation',
17241724
},

src/packages/block/block-grid/components/block-grid-area-config-entry/block-grid-area-config-entry.context.ts

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1+
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
2+
import { UmbObjectState, appendToFrozenArray } from '@umbraco-cms/backoffice/observable-api';
3+
import { UmbContextBase } from '@umbraco-cms/backoffice/class-api';
4+
import { UMB_PROPERTY_CONTEXT } from '@umbraco-cms/backoffice/property';
5+
import { umbConfirmModal } from '@umbraco-cms/backoffice/modal';
6+
import { UMB_BLOCK_GRID_AREA_TYPE_ENTRIES_CONTEXT } from '../../property-editors/block-grid-areas-config/block-grid-area-type-entries.context-token.js';
17
import {
28
UmbBlockGridScaleManager,
39
type UmbBlockGridScalableContext,
410
} from '../../context/block-grid-scale-manager/block-grid-scale-manager.controller.js';
5-
import { UMB_BLOCK_GRID_AREA_TYPE_ENTRIES_CONTEXT } from '../../property-editors/block-grid-areas-config/block-grid-area-type-entries.context-token.js';
611
import { UMB_BLOCK_GRID_AREA_CONFIG_ENTRY_CONTEXT } from './block-grid-area-config-entry.context-token.js';
712
import type { UmbBlockGridTypeAreaType } from '@umbraco-cms/backoffice/block-grid';
8-
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
9-
import { UmbObjectState } from '@umbraco-cms/backoffice/observable-api';
10-
import { UmbContextBase } from '@umbraco-cms/backoffice/class-api';
11-
import { UMB_PROPERTY_CONTEXT } from '@umbraco-cms/backoffice/property';
12-
import { umbConfirmModal } from '@umbraco-cms/backoffice/modal';
1313
export class UmbBlockGridAreaConfigEntryContext
1414
extends UmbContextBase<UmbBlockGridAreaConfigEntryContext>
1515
implements UmbBlockGridScalableContext
@@ -21,6 +21,7 @@ export class UmbBlockGridAreaConfigEntryContext
2121
//
2222
#areaKey?: string;
2323
#area = new UmbObjectState<UmbBlockGridTypeAreaType | undefined>(undefined);
24+
readonly area = this.#area.asObservable();
2425
readonly alias = this.#area.asObservablePart((x) => x?.alias);
2526
readonly columnSpan = this.#area.asObservablePart((x) => x?.columnSpan);
2627
readonly rowSpan = this.#area.asObservablePart((x) => x?.rowSpan ?? 1);
@@ -85,7 +86,19 @@ export class UmbBlockGridAreaConfigEntryContext
8586
this.#area.setValue(areaType);
8687
}
8788
},
88-
'observeAreaKey',
89+
'observeAreaData',
90+
);
91+
this.observe(
92+
this.area,
93+
(area) => {
94+
if (area && this.#propertyContext) {
95+
const value = this.#propertyContext.getValue() as Array<UmbBlockGridTypeAreaType> | undefined;
96+
if (!value) return;
97+
const newValue = appendToFrozenArray(value, area, (x) => x.key === this.#areaKey);
98+
this.#propertyContext?.setValue(newValue);
99+
}
100+
},
101+
'observeInternalArea',
89102
);
90103
}
91104

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1+
export * from './entity.js';
2+
export * from './global-components/index.js';
13
export * from './repository/index.js';
24
export * from './tree/index.js';
35
export * from './types.js';
4-
export * from './entity.js';
5-
export * from './global-components/index.js';
66
export * from './workspace/script-workspace.context-token.js';
77

88
export { UMB_SCRIPT_PICKER_MODAL } from './modals/script-picker-modal.token.js';

0 commit comments

Comments
 (0)