Skip to content

Commit 6c1fc66

Browse files
Merge branch 'main' into v14/chore/bundling-language-package
2 parents 6e04c9d + 6f74832 commit 6c1fc66

File tree

7 files changed

+46
-10
lines changed

7 files changed

+46
-10
lines changed

src/libs/context-api/consume/context-consumer.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { expect, oneEvent } from '@open-wc/testing';
22
import { UmbContextProvider } from '../provide/context-provider.js';
33
import { UmbContextToken } from '../token/context-token.js';
44
import { UmbContextConsumer } from './context-consumer.js';
5-
import type { UmbContextRequestEventImplementation} from './context-request.event.js';
5+
import type { UmbContextRequestEventImplementation } from './context-request.event.js';
66
import { UMB_CONTENT_REQUEST_EVENT_TYPE } from './context-request.event.js';
77

88
const testContextAlias = 'my-test-context';
@@ -39,7 +39,7 @@ describe('UmbContextConsumer', () => {
3939

4040
describe('events', () => {
4141
it('dispatches context request event when constructed', async () => {
42-
const listener = oneEvent(window, UMB_CONTENT_REQUEST_EVENT_TYPE, false);
42+
const listener = oneEvent(window, UMB_CONTENT_REQUEST_EVENT_TYPE);
4343

4444
consumer.hostConnected();
4545

src/packages/core/property/property-dataset/property-dataset.element.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ describe('UmbBasicVariantElement', () => {
133133
});
134134

135135
it('fires change event', async () => {
136-
const listener = oneEvent(datasetElement, UmbChangeEvent.TYPE, false);
136+
const listener = oneEvent(datasetElement, UmbChangeEvent.TYPE);
137137

138138
expect(propertyEditor.alias).to.eq('testAlias');
139139
propertyEditor.setValue('testValue3');
@@ -153,7 +153,7 @@ describe('UmbBasicVariantElement', () => {
153153
adapterPropertyEditor.alias = 'testAdapterAlias';
154154
datasetElement.appendChild(adapterPropertyEditor);
155155

156-
const listener = oneEvent(datasetElement, UmbChangeEvent.TYPE, false);
156+
const listener = oneEvent(datasetElement, UmbChangeEvent.TYPE);
157157

158158
// The alias of the original property editor must be 'testAlias' for the adapter to set the value of it.
159159
expect(propertyEditor.alias).to.eq('testAlias');

src/packages/core/utils/pagination-manager/pagination.manager.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ describe('UmbPaginationManager', () => {
141141
});
142142

143143
it('dispatches a change event', async () => {
144-
const listener = oneEvent(manager, UmbChangeEvent.TYPE, false);
144+
const listener = oneEvent(manager, UmbChangeEvent.TYPE);
145145
manager.setCurrentPageNumber(2);
146146
const event = (await listener) as unknown as UmbChangeEvent;
147147
const target = event.target as UmbPaginationManager;

src/packages/user/user-group/components/input-user-group/user-group-input.element.ts

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
1+
import { UMB_USER_GROUP_ENTITY_TYPE } from '../../entity.js';
12
import type { UmbUserGroupItemModel } from '../../repository/index.js';
23
import { UmbUserGroupPickerContext } from './user-group-input.context.js';
34
import { css, html, customElement, property, state, ifDefined, nothing } from '@umbraco-cms/backoffice/external/lit';
45
import { UUIFormControlMixin } from '@umbraco-cms/backoffice/external/uui';
56
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
7+
import { UMB_WORKSPACE_MODAL } from '@umbraco-cms/backoffice/modal';
8+
import { UmbModalRouteRegistrationController } from '@umbraco-cms/backoffice/router';
69
import { splitStringToArray } from '@umbraco-cms/backoffice/utils';
710

811
@customElement('umb-user-group-input')
@@ -74,6 +77,9 @@ export class UmbUserGroupInputElement extends UUIFormControlMixin(UmbLitElement,
7477

7578
#pickerContext = new UmbUserGroupPickerContext(this);
7679

80+
@state()
81+
private _editUserGroupPath = '';
82+
7783
constructor() {
7884
super();
7985

@@ -91,6 +97,15 @@ export class UmbUserGroupInputElement extends UUIFormControlMixin(UmbLitElement,
9197

9298
this.observe(this.#pickerContext.selection, (selection) => (this.value = selection.join(',')), '_observeSelection');
9399
this.observe(this.#pickerContext.selectedItems, (selectedItems) => (this._items = selectedItems), '_observerItems');
100+
101+
new UmbModalRouteRegistrationController(this, UMB_WORKSPACE_MODAL)
102+
.addAdditionalPath(UMB_USER_GROUP_ENTITY_TYPE)
103+
.onSetup(async () => {
104+
return { data: { entityType: UMB_USER_GROUP_ENTITY_TYPE, preset: {} } };
105+
})
106+
.observeRouteBuilder((routeBuilder) => {
107+
this._editUserGroupPath = routeBuilder({});
108+
});
94109
}
95110

96111
protected getFormElement() {
@@ -110,8 +125,9 @@ export class UmbUserGroupInputElement extends UUIFormControlMixin(UmbLitElement,
110125

111126
private _renderItem(item: UmbUserGroupItemModel) {
112127
if (!item.unique) return;
128+
const href = `${this._editUserGroupPath}edit/${item.unique}`;
113129
return html`
114-
<umb-user-group-ref name="${ifDefined(item.name)}">
130+
<umb-user-group-ref name="${ifDefined(item.name)}" href=${href}>
115131
${item.icon ? html`<umb-icon slot="icon" name=${item.icon}></umb-icon>` : nothing}
116132
<uui-action-bar slot="actions">
117133
<uui-button

src/packages/user/user/components/user-document-start-node/user-document-start-node.element.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ export class UmbUserDocumentStartNodeElement extends UmbLitElement {
88
@property({ type: Array, attribute: false })
99
uniques: Array<string> = [];
1010

11+
@property({ type: Boolean })
12+
readonly = false;
13+
1114
@state()
1215
_displayValue: Array<UmbDocumentItemModel> = [];
1316

@@ -22,7 +25,10 @@ export class UmbUserDocumentStartNodeElement extends UmbLitElement {
2225
render() {
2326
if (this.uniques.length < 1) {
2427
return html`
25-
<uui-ref-node name="Content Root">
28+
<uui-ref-node
29+
name="Content Root"
30+
?disabled=${this.readonly}
31+
style="--uui-color-disabled-contrast: var(--uui-color-text)">
2632
<uui-icon slot="icon" name="folder"></uui-icon>
2733
</uui-ref-node>
2834
`;
@@ -34,7 +40,10 @@ export class UmbUserDocumentStartNodeElement extends UmbLitElement {
3440
(item) => {
3541
return html`
3642
<!-- TODO: get correct variant name -->
37-
<uui-ref-node name=${item.variants[0]?.name}>
43+
<uui-ref-node
44+
name=${item.variants[0]?.name}
45+
?disabled=${this.readonly}
46+
style="--uui-color-disabled-contrast: var(--uui-color-text)">
3847
<uui-icon slot="icon" name="folder"></uui-icon>
3948
</uui-ref-node>
4049
`;

src/packages/user/user/components/user-media-start-node/user-media-start-node.element.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ export class UmbUserMediaStartNodeElement extends UmbLitElement {
88
@property({ type: Array, attribute: false })
99
uniques: Array<string> = [];
1010

11+
@property({ type: Boolean })
12+
readonly = false;
13+
1114
@state()
1215
_displayValue: Array<UmbMediaItemModel> = [];
1316

@@ -22,7 +25,10 @@ export class UmbUserMediaStartNodeElement extends UmbLitElement {
2225
render() {
2326
if (this.uniques.length < 1) {
2427
return html`
25-
<uui-ref-node name="Media Root">
28+
<uui-ref-node
29+
name="Media Root"
30+
?disabled=${this.readonly}
31+
style="--uui-color-disabled-contrast: var(--uui-color-text)">
2632
<uui-icon slot="icon" name="folder"></uui-icon>
2733
</uui-ref-node>
2834
`;
@@ -34,7 +40,10 @@ export class UmbUserMediaStartNodeElement extends UmbLitElement {
3440
(item) => {
3541
return html`
3642
<!-- TODO: get correct variant name -->
37-
<uui-ref-node name=${ifDefined(item.variants[0]?.name)}>
43+
<uui-ref-node
44+
name=${ifDefined(item.variants[0]?.name)}
45+
?disabled=${this.readonly}
46+
style="--uui-color-disabled-contrast: var(--uui-color-text)">
3847
<uui-icon slot="icon" name="folder"></uui-icon>
3948
</uui-ref-node>
4049
`;

src/packages/user/user/workspace/components/user-workspace-access/user-workspace-access.element.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,15 @@ export class UmbUserWorkspaceAccessElement extends UmbLitElement {
4040
#renderDocumentStartNodes() {
4141
return html` <b><umb-localize key="sections_content">Content</umb-localize></b>
4242
<umb-user-document-start-node
43+
readonly
4344
.uniques=${this._user?.documentStartNodeUniques.map((reference) => reference.unique) ||
4445
[]}></umb-user-document-start-node>`;
4546
}
4647

4748
#renderMediaStartNodes() {
4849
return html` <b><umb-localize key="sections_media">Media</umb-localize></b>
4950
<umb-user-media-start-node
51+
readonly
5052
.uniques=${this._user?.mediaStartNodeUniques.map((reference) => reference.unique) ||
5153
[]}></umb-user-media-start-node>`;
5254
}

0 commit comments

Comments
 (0)