Skip to content

Commit 76d82e1

Browse files
committed
initial override corrections
1 parent b78713a commit 76d82e1

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

src/packages/core/lit-element/lit-element.element.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import { LitElement, property } from '@umbraco-cms/backoffice/external/lit';
22
import { UmbElementMixin } from '@umbraco-cms/backoffice/element-api';
33

4-
// TODO: Currently we don't check if the `lang` is registered in the backoffice. We should do that. We can do that by checking if the `lang` is in the `languages` array of the `language` resource and potentially make sure that UmbLocalizationRegistry only loads the localizations and some other mechanism reloads to another language (currently it does both)
5-
64
/**
75
* The base class for all Umbraco LitElement elements.
86
*
@@ -19,7 +17,7 @@ export class UmbLitElement extends UmbElementMixin(LitElement) {
1917
* @example 'ltr'
2018
* @example 'rtl'
2119
*/
22-
@property() dir: 'rtl' | 'ltr' | '' = '';
20+
@property() override dir: 'rtl' | 'ltr' | '' = '';
2321

2422
/**
2523
* The language of the element.
@@ -29,5 +27,5 @@ export class UmbLitElement extends UmbElementMixin(LitElement) {
2927
* @example 'en-us'
3028
* @example 'en'
3129
*/
32-
@property() lang = '';
30+
@property() override lang = '';
3331
}

src/packages/language/workspace/language/language-workspace.context.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
import { UmbLanguageDetailRepository } from '../../repository/index.js';
2-
import type { UmbLanguageDetailModel } from '../../types.js';
3-
import { UmbLanguageWorkspaceEditorElement } from './language-workspace-editor.element.js';
41
import {
52
type UmbSubmittableWorkspaceContext,
63
UmbSubmittableWorkspaceContextBase,
@@ -10,6 +7,9 @@ import {
107
} from '@umbraco-cms/backoffice/workspace';
118
import { UmbObjectState } from '@umbraco-cms/backoffice/observable-api';
129
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
10+
import { UmbLanguageDetailRepository } from '../../repository/index.js';
11+
import type { UmbLanguageDetailModel } from '../../types.js';
12+
import { UmbLanguageWorkspaceEditorElement } from './language-workspace-editor.element.js';
1313

1414
export class UmbLanguageWorkspaceContext
1515
extends UmbSubmittableWorkspaceContextBase<UmbLanguageDetailModel>
@@ -27,8 +27,6 @@ export class UmbLanguageWorkspaceContext
2727
#validationErrors = new UmbObjectState<any | undefined>(undefined);
2828
readonly validationErrors = this.#validationErrors.asObservable();
2929

30-
readonly routes = new UmbWorkspaceRouteManager(this);
31-
3230
constructor(host: UmbControllerHost) {
3331
super(host, 'Umb.Workspace.Language');
3432

0 commit comments

Comments
 (0)