Skip to content

Commit 840d411

Browse files
loivseniOvergaard
authored andcommitted
dont insert partialviews in partialviews
1 parent 46d5336 commit 840d411

File tree

3 files changed

+30
-20
lines changed

3 files changed

+30
-20
lines changed

src/packages/templating/components/templating-item-menu/templating-item-menu.element.ts

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ export class UmbTemplatingInsertMenuElement extends UmbLitElement {
1818
@property()
1919
value = '';
2020

21+
@property({ type: Boolean })
22+
hidePartialViews = false;
23+
2124
#modalContext?: UmbModalManagerContext;
2225

2326
#dictionaryDetailRepository = new UmbDictionaryDetailRepository(this);
@@ -58,7 +61,9 @@ export class UmbTemplatingInsertMenuElement extends UmbLitElement {
5861
}
5962

6063
async #openTemplatingItemPickerModal() {
61-
const itemPickerContext = this.#modalContext?.open(this, UMB_TEMPLATING_ITEM_PICKER_MODAL);
64+
const itemPickerContext = this.#modalContext?.open(this, UMB_TEMPLATING_ITEM_PICKER_MODAL, {
65+
data: { hidePartialViews: this.hidePartialViews },
66+
});
6267
const result = await itemPickerContext?.onSubmit().catch(() => undefined);
6368

6469
if (result === undefined) return;
@@ -135,12 +140,14 @@ export class UmbTemplatingInsertMenuElement extends UmbLitElement {
135140
label=${this.localize.term('template_insertPageField')}
136141
title=${this.localize.term('template_insertPageField')}
137142
@click=${this.#openPageFieldBuilderModal}></uui-menu-item>
138-
<uui-menu-item
139-
class="insert-menu-item"
140-
label=${this.localize.term('template_insertPartialView')}
141-
title=${this.localize.term('template_insertPartialView')}
142-
@click=${this.#openPartialViewPickerModal}>
143-
</uui-menu-item>
143+
${!this.hidePartialViews
144+
? html`<uui-menu-item
145+
class="insert-menu-item"
146+
label=${this.localize.term('template_insertPartialView')}
147+
title=${this.localize.term('template_insertPartialView')}
148+
@click=${this.#openPartialViewPickerModal}>
149+
</uui-menu-item>`
150+
: ''}
144151
<uui-menu-item
145152
class="insert-menu-item"
146153
label=${this.localize.term('template_insertDictionaryItem')}

src/packages/templating/modals/templating-item-picker/templating-item-picker-modal.element.ts

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -106,18 +106,20 @@ export class UmbTemplatingItemPickerModalElement extends UmbModalBaseElement<
106106
</umb-localize>
107107
</p>
108108
</uui-button>
109-
<uui-button
110-
@click=${this.#openPartialViewPickerModal}
111-
look="placeholder"
112-
label=${this.localize.term('template_insert')}>
113-
<h3><umb-localize key="template_insertPartialView">Partial view</umb-localize></h3>
114-
<p>
115-
<umb-localize key="template_insertPartialViewDesc">
116-
A partial view is a separate template file which can be rendered inside another template, it's great for
117-
reusing markup or for separating complex templates into separate files.
118-
</umb-localize>
119-
</p>
120-
</uui-button>
109+
${!this.data?.hidePartialViews
110+
? html`<uui-button
111+
@click=${this.#openPartialViewPickerModal}
112+
look="placeholder"
113+
label=${this.localize.term('template_insert')}>
114+
<h3><umb-localize key="template_insertPartialView">Partial view</umb-localize></h3>
115+
<p>
116+
<umb-localize key="template_insertPartialViewDesc">
117+
A partial view is a separate template file which can be rendered inside another template, it's great for
118+
reusing markup or for separating complex templates into separate files.
119+
</umb-localize>
120+
</p>
121+
</uui-button>`
122+
: ''}
121123
<uui-button
122124
@click=${this.#openDictionaryItemPickerModal}
123125
look="placeholder"

src/packages/templating/partial-views/workspace/partial-view-workspace-editor.element.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ export class UmbPartialViewWorkspaceEditorElement extends UmbLitElement {
102102
</div>
103103
<uui-box>
104104
<div slot="header" id="code-editor-menu-container">
105-
<umb-templating-insert-menu @insert=${this.#insertSnippet}></umb-templating-insert-menu>
105+
<umb-templating-insert-menu @insert=${this.#insertSnippet} hidePartialViews></umb-templating-insert-menu>
106106
<uui-button
107107
look="secondary"
108108
id="query-builder-button"
@@ -183,6 +183,7 @@ export class UmbPartialViewWorkspaceEditorElement extends UmbLitElement {
183183
display: flex;
184184
justify-content: flex-end;
185185
gap: var(--uui-size-space-3);
186+
width: 100%;
186187
}
187188
`,
188189
];

0 commit comments

Comments
 (0)