Skip to content

Commit 93a9c69

Browse files
committed
do not pass variant ids to validate create
1 parent e6130d8 commit 93a9c69

File tree

3 files changed

+5
-14
lines changed

3 files changed

+5
-14
lines changed

src/packages/documents/documents/repository/validation/document-validation.repository.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,13 @@ export class UmbDocumentValidationRepository extends UmbRepositoryBase {
1919
* Returns a promise with an observable of the detail for the given unique
2020
* @param {DetailModelType} model
2121
* @param {string | null} [parentUnique]
22-
* @param variantIds
2322
* @returns {*}
2423
* @memberof UmbDetailRepositoryBase
2524
*/
26-
async validateCreate(model: DetailModelType, parentUnique: string | null, variantIds: Array<UmbVariantId>) {
25+
async validateCreate(model: DetailModelType, parentUnique: string | null) {
2726
if (!model) throw new Error('Data is missing');
2827

29-
return this.#validationDataSource.validateCreate(model, parentUnique, variantIds);
28+
return this.#validationDataSource.validateCreate(model, parentUnique);
3029
}
3130

3231
/**

src/packages/documents/documents/repository/validation/document-validation.server.data-source.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,27 +33,19 @@ export class UmbDocumentValidationServerDataSource {
3333
* @param parentUnique
3434
* @returns {*}
3535
*/
36-
async validateCreate(
37-
model: UmbDocumentDetailModel,
38-
parentUnique: string | null = null,
39-
variantIds: Array<UmbVariantId>,
40-
) {
36+
async validateCreate(model: UmbDocumentDetailModel, parentUnique: string | null = null) {
4137
if (!model) throw new Error('Document is missing');
4238
if (!model.unique) throw new Error('Document unique is missing');
4339
if (parentUnique === undefined) throw new Error('Parent unique is missing');
44-
if (!variantIds) throw new Error('Variant ids are missing');
45-
46-
const cultures = variantIds.map((id) => id.culture).filter((culture) => culture !== null);
4740

4841
// TODO: make data mapper to prevent errors
49-
const requestBody: ValidateCreateDocumentRequestModel = {
42+
const requestBody: CreateDocumentRequestModel = {
5043
id: model.unique,
5144
parent: parentUnique ? { id: parentUnique } : null,
5245
documentType: { id: model.documentType.unique },
5346
template: model.template ? { id: model.template.unique } : null,
5447
values: model.values,
5548
variants: model.variants,
56-
cultures,
5749
};
5850

5951
// Maybe use: tryExecuteAndNotify

src/packages/documents/documents/workspace/document-workspace.context.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -714,7 +714,7 @@ export class UmbDocumentWorkspaceContext
714714
if (!parent) throw new Error('Parent is not set');
715715
this.#serverValidation.askServerForValidation(
716716
saveData,
717-
this.#validationRepository.validateCreate(saveData, parent.unique, variantIds),
717+
this.#validationRepository.validateCreate(saveData, parent.unique),
718718
);
719719
} else {
720720
this.#serverValidation.askServerForValidation(

0 commit comments

Comments
 (0)