Skip to content

Commit a820ea8

Browse files
committed
remove unused vars
1 parent 5550371 commit a820ea8

File tree

39 files changed

+33
-79
lines changed

39 files changed

+33
-79
lines changed

src/libs/controller-api/controller.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ describe('UmbController', () => {
5151
let hostElement: UmbControllerHostElement;
5252

5353
beforeEach(() => {
54-
hostElement = document.createElement('test-my-controller-host') as UmbControllerHostElement;
54+
hostElement = new UmbTestControllerHostElement();
5555
});
5656

5757
describe('Controller Host Public API', () => {

src/mocks/data/document/document.db.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ export class UmbDocumentMockDB extends UmbEntityMockDbBase<UmbMockDocumentModel>
3333
}
3434

3535
// permissions
36-
getUserPermissionsForDocument(id: string): Array<any> {
36+
getUserPermissionsForDocument(): Array<any> {
3737
return [];
3838
}
3939

40-
getDomainsForDocument(id: string): DomainsResponseModel {
40+
getDomainsForDocument(): DomainsResponseModel {
4141
return { defaultIsoCode: 'en-us', domains: [] };
4242
}
4343

src/mocks/data/media/media-collection.manager.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ export class UmbMockMediaCollectionManager {
1414

1515
getCollectionMedia({
1616
id,
17-
dataTypeId,
18-
orderBy,
19-
orderDirection,
20-
filter,
2117
skip = 0,
2218
take = 100,
2319
}: {

src/mocks/data/user/user.db.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { umbUserGroupMockDb } from '../user-group/user-group.db.js';
2-
import { arrayFilter, stringFilter, queryFilter, objectArrayFilter } from '../utils.js';
2+
import { stringFilter, queryFilter, objectArrayFilter } from '../utils.js';
33
import { UmbEntityMockDbBase } from '../utils/entity/entity-base.js';
44
import { UmbMockEntityItemManager } from '../utils/entity/entity-item.manager.js';
55
import { UmbMockEntityDetailManager } from '../utils/entity/entity-detail.manager.js';

src/mocks/data/utils/content/content-collection.manager.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
import { queryFilter } from '../../utils.js';
21
import type { UmbMockDBBase } from '../mock-db-base.js';
32
import { pagedResult } from '../paged-result.js';
43

5-
const contentQueryFilter = (filterOptions: any, item: any) => {
4+
const contentQueryFilter = () => {
65
return true;
76
console.log('implement filter logic for content items');
87
//queryFilter(filterOptions.filter, item.name);

src/mocks/handlers/webhook.handlers.ts

Lines changed: 0 additions & 4 deletions
This file was deleted.

src/packages/block/block-list/context/block-list-manager.context.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ export class UmbBlockListManagerContext<
2121
create(
2222
contentElementTypeKey: string,
2323
partialLayoutEntry?: Omit<BlockLayoutType, 'contentUdi'>,
24+
// TODO: [v15] ignoring unused modalData parameter to avoid breaking changes
25+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
2426
modalData?: UmbBlockListWorkspaceData,
2527
) {
2628
return super.createBlockData(contentElementTypeKey, partialLayoutEntry);

src/packages/block/block-type/workspace/block-type-workspace.context.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,9 @@ export class UmbBlockTypeWorkspaceContext<BlockTypeData extends UmbBlockTypeWith
133133
getName() {
134134
return 'block name content element type here...';
135135
}
136+
137+
// TODO: [v15] ignoring unused name parameter to avoid breaking changes
138+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
136139
setName(name: string | undefined) {
137140
console.warn('You cannot set a name of a block type.');
138141
}

src/packages/block/block/context/block-manager.context.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ export abstract class UmbBlockManagerContext<
167167
return this.#contents.value.find((x) => x.udi === contentUdi);
168168
}
169169

170-
setOneLayout(layoutData: BlockLayoutType, modalData?: UmbBlockWorkspaceData) {
170+
setOneLayout(layoutData: BlockLayoutType) {
171171
this._layouts.appendOne(layoutData);
172172
}
173173
setOneContent(contentData: UmbBlockDataType) {
@@ -264,6 +264,8 @@ export abstract class UmbBlockManagerContext<
264264
layoutEntry: BlockLayoutType,
265265
content: UmbBlockDataType,
266266
settings: UmbBlockDataType | undefined,
267+
// TODO: [v15]: ignoring unused var here here to prevent a breaking change
268+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
267269
modalData: ModalDataType,
268270
) {
269271
// Create content entry:

src/packages/core/components/multiple-color-picker-input/multiple-color-picker-input.element.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,5 @@
11
import type { UmbMultipleColorPickerItemInputElement } from './multiple-color-picker-item-input.element.js';
2-
import {
3-
css,
4-
customElement,
5-
html,
6-
ifDefined,
7-
nothing,
8-
repeat,
9-
property,
10-
state,
11-
} from '@umbraco-cms/backoffice/external/lit';
2+
import { css, customElement, html, nothing, repeat, property, state } from '@umbraco-cms/backoffice/external/lit';
123
import { UUIFormControlMixin } from '@umbraco-cms/backoffice/external/uui';
134
import { UmbChangeEvent } from '@umbraco-cms/backoffice/event';
145
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';

0 commit comments

Comments
 (0)