Merge branch 'main' into v15/feature/emm-picker-search-result-item

# Conflicts:
#	src/packages/core/extension-registry/models/index.ts

Author: nielslyngsoe

examples/dashboard-with-property-dataset/index.ts

@@ -1,4 +1,4 @@
-import type { ManifestDashboard } from '@umbraco-cms/backoffice/extension-registry';
+import type { ManifestDashboard } from '@umbraco-cms/backoffice/dashboard';
 
 export const manifests: Array<ManifestDashboard> = [
 	{

examples/manifest-picker/index.ts

@@ -1,4 +1,4 @@
-import type { ManifestDashboard } from '@umbraco-cms/backoffice/extension-registry';
+import type { ManifestDashboard } from '@umbraco-cms/backoffice/dashboard';
 
 export const manifests: Array<ManifestDashboard> = [
 	{

examples/sorter-with-nested-containers/index.ts

@@ -1,4 +1,4 @@
-import type { ManifestDashboard } from '@umbraco-cms/backoffice/extension-registry';
+import type { ManifestDashboard } from '@umbraco-cms/backoffice/dashboard';
 
 export const manifests: Array<ManifestDashboard> = [
 	{

examples/sorter-with-two-containers/index.ts

@@ -1,4 +1,4 @@
-import type { ManifestDashboard } from '@umbraco-cms/backoffice/extension-registry';
+import type { ManifestDashboard } from '@umbraco-cms/backoffice/dashboard';
 
 export const manifests: Array<ManifestDashboard> = [
 	{

package.json

@@ -32,6 +32,7 @@
 		"./culture": "./dist-cms/packages/core/culture/index.js",
 		"./picker": "./dist-cms/packages/core/picker/index.js",
 		"./current-user": "./dist-cms/packages/user/current-user/index.js",
+		"./dashboard": "./dist-cms/packages/core/dashboard/index.js",
 		"./data-type": "./dist-cms/packages/data-type/index.js",
 		"./debug": "./dist-cms/packages/core/debug/index.js",
 		"./dictionary": "./dist-cms/packages/dictionary/index.js",

src/external/backend-api/src/types.gen.ts

@@ -488,6 +488,7 @@ export type DataTypeItemResponseModel = {
     id: string;
     name: string;
     editorUiAlias?: (string) | null;
+    editorAlias: string;
     isDeletable: boolean;
 };
 

src/libs/class-api/class.interface.ts

@@ -12,7 +12,8 @@ export interface UmbClassInterface extends UmbControllerHost {
 	/**
 	 * @description Observe an Observable. An Observable is a declared source of data that can be observed. An observables is declared from a UmbState.
 	 * @param {Observable} source An Observable to observe from.
-	 * @param {ObserverCallback} callback Callback method called when data is changed.
+	 * @param {ObserverCallback | undefined} callback Callback method called when data is changed.
+	 * @param {UmbControllerAlias | null | undefined} controllerAlias Define an explicit controller alias. If not defined then one will be generated based on the callback function. If null is parsed no controller alias will be given.
 	 * @returns {UmbObserverController} Reference to the created Observer Controller instance.
 	 * @memberof UmbClassInterface
 	 */
@@ -30,7 +31,7 @@ export interface UmbClassInterface extends UmbControllerHost {
 	>(
 		// This type dance checks if the Observable given could be undefined, if it potentially could be undefined it means that this potentially could return undefined and then call the callback with undefined. [NL]
 		source: ObservableType,
-		callback: ObserverCallback<SpecificT>,
+		callback?: ObserverCallback<SpecificT>,
 		controllerAlias?: UmbControllerAlias | null,
 	): SpecificR;
 

src/libs/extension-api/registry/extension.registry.ts

@@ -414,6 +414,21 @@ export class UmbExtensionRegistry<
 		) as Observable<Array<T>>;
 	}
 
+	// TODO: Write test for this method:
+	getByTypeAndFilter<
+		Key extends string,
+		T extends ManifestBase = SpecificManifestTypeOrManifestBase<ManifestTypes, Key>,
+	>(type: Key, filter: (ext: T) => boolean): Array<T> {
+		const exts = this._extensions
+			.getValue()
+			.filter((ext) => ext.type === type && filter(ext as unknown as T)) as unknown as T[];
+		if (exts.length === 0) {
+			return [];
+		}
+		const kinds = this._kinds.getValue();
+		return exts.map((ext) => (ext?.kind ? (this.#mergeExtensionWithKinds([ext, kinds]) ?? ext) : ext));
+	}
+
 	/**
 	 * Get an observable of extensions by types and a given filter method.
 	 * This will return the all extensions that matches the types and which filter method returns true.

src/libs/observable-api/states/array-state.ts

@@ -23,6 +23,7 @@ export class UmbArrayState<T> extends UmbDeepState<T[]> {
 	/**
 	 * @function sortBy
 	 * @param {(a: T, b: T) => number} sortMethod - A method to be used for sorting every time data is set.
+	 * @returns {UmbArrayState<T>} Reference to it self.
 	 * @description - A sort method to this Subject.
 	 * @example <caption>Example add sort method</caption>
 	 * const data = [
@@ -53,7 +54,7 @@ export class UmbArrayState<T> extends UmbDeepState<T[]> {
 	 * // myState.value is equal 'Goodnight'.
 	 */
 	override setValue(value: T[]) {
-		if (this.#sortMethod) {
+		if (value && this.#sortMethod) {
 			super.setValue([...value].sort(this.#sortMethod));
 		} else {
 			super.setValue(value);
@@ -76,6 +77,7 @@ export class UmbArrayState<T> extends UmbDeepState<T[]> {
 	remove(uniques: unknown[]) {
 		if (this.getUniqueMethod) {
 			let next = this.getValue();
+			if (!next) return this;
 			uniques.forEach((unique) => {
 				next = next.filter((x) => {
 					// eslint-disable-next-line @typescript-eslint/ban-ts-comment
@@ -105,6 +107,7 @@ export class UmbArrayState<T> extends UmbDeepState<T[]> {
 	removeOne(unique: unknown) {
 		if (this.getUniqueMethod) {
 			let next = this.getValue();
+			if (!next) return this;
 			next = next.filter((x) => {
 				// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 				// @ts-ignore
@@ -138,7 +141,10 @@ export class UmbArrayState<T> extends UmbDeepState<T[]> {
 	 * ]
 	 */
 	filter(predicate: (value: T, index: number, array: T[]) => boolean) {
-		this.setValue(this.getValue().filter(predicate));
+		const value = this.getValue();
+		if (value) {
+			this.setValue(value.filter(predicate));
+		}
 		return this;
 	}
 

src/mocks/data/data-type/data-type.db.ts

@@ -82,6 +82,7 @@ const itemResponseMapper = (item: UmbMockDataTypeModel): DataTypeItemResponseMod
 	return {
 		id: item.id,
 		name: item.name,
+		editorAlias: item.editorAlias,
 		isDeletable: item.isDeletable,
 	};
 };