Skip to content

Commit b49313f

Browse files
committed
catch the error instead of relying on a timeout
1 parent 6895d4d commit b49313f

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

src/packages/core/extension-registry/utils/create-extension-api-by-alias.test.ts

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ describe('Create Extension Api By Alias Method', () => {
4646
hostElement = await fixture(html`<umb-test-controller-host></umb-test-controller-host>`);
4747
});
4848

49-
/*
5049
it('Returns `undefined` when manifest does not have any correct properties', (done) => {
5150
const manifest: ManifestApi = {
5251
type: 'my-test-type',
@@ -55,17 +54,17 @@ describe('Create Extension Api By Alias Method', () => {
5554
};
5655
umbExtensionsRegistry.register(manifest);
5756

58-
createExtensionApiByAlias<UmbExtensionApiBoolTestClass>(hostElement, manifest.alias, []).then(() => {
59-
umbExtensionsRegistry.unregister(manifest.alias);
60-
done(new Error('Should not resolve'));
61-
});
62-
63-
setTimeout(() => {
64-
umbExtensionsRegistry.unregister(manifest.alias);
65-
done();
66-
}, 10);
57+
createExtensionApiByAlias<UmbExtensionApiBoolTestClass>(hostElement, manifest.alias, []).then(
58+
() => {
59+
umbExtensionsRegistry.unregister(manifest.alias);
60+
done(new Error('Should not resolve'));
61+
},
62+
() => {
63+
umbExtensionsRegistry.unregister(manifest.alias);
64+
done();
65+
},
66+
);
6767
});
68-
*/
6968

7069
it('Handles when `api` property contains a class constructor', async () => {
7170
const manifest: ManifestApi<UmbExtensionApiTrueTestClass> = {

0 commit comments

Comments
 (0)