Merge pull request #2110 from umbraco/v14/chore/eslint-more-rules

Test: Enable more FlatConfig ESLint rules

Author: loivsen

devops/eslint/rules/no-direct-api-import.cjs

@@ -1,3 +1,4 @@
+/** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
 	meta: {
 		docs: {

eslint.config.js

@@ -4,25 +4,28 @@ import importPlugin from 'eslint-plugin-import';
 import localRules from 'eslint-plugin-local-rules';
 import wcPlugin from 'eslint-plugin-wc';
 import litPlugin from 'eslint-plugin-lit';
-import litA11yPlugin from 'eslint-plugin-lit-a11y';
-import storybookPlugin from 'eslint-plugin-storybook';
 import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended';
 import tseslint from 'typescript-eslint';
 
 export default [
 	// Recommended config applied to all files
 	js.configs.recommended,
 	...tseslint.configs.recommended,
+	wcPlugin.configs['flat/recommended'],
+	litPlugin.configs['flat/recommended'],
+	localRules.configs.all,
 	eslintPluginPrettierRecommended,
 
 	// Global ignores
 	{
 		ignores: [
+			'**/eslint.config.js',
 			'**/rollup.config.js',
 			'**/vite.config.ts',
 			'src/external',
 			'src/packages/core/icon-registry/icons',
 			'src/packages/core/icon-registry/icons.ts',
+			'src/**/*.test.ts',
 		],
 	},
 
@@ -40,29 +43,19 @@ export default [
 		plugins: {
 			import: importPlugin,
 			'local-rules': localRules,
-			wc: wcPlugin,
-			lit: litPlugin,
-			'lit-a11y': litA11yPlugin,
-			storybook: storybookPlugin,
 		},
 		rules: {
 			semi: ['warn', 'always'],
-			"prettier/prettier": ["warn", {"endOfLine": "auto" }],
+			"prettier/prettier": ["warn", { "endOfLine": "auto" }],
 			'no-unused-vars': 'off', //Let '@typescript-eslint/no-unused-vars' catch the errors to allow unused function parameters (ex: in interfaces)
 			'no-var': 'error',
+			...importPlugin.configs.recommended.rules,
+			'import/namespace': 'off',
 			'import/no-unresolved': 'off',
 			'import/order': ['warn', { groups: ['builtin', 'parent', 'sibling', 'index', 'external'] }],
 			'import/no-self-import': 'error',
 			'import/no-cycle': ['error', { maxDepth: 6, allowUnsafeDynamicCyclicDependency: true }],
-			'local-rules/bad-type-import': 'error',
-			'local-rules/enforce-element-suffix-on-element-class-name': 'error',
-			'local-rules/enforce-umb-prefix-on-element-name': 'error',
-			'local-rules/ensure-relative-import-use-js-extension': 'error',
-			'local-rules/no-direct-api-import': 'warn',
-			'local-rules/prefer-import-aliases': 'error',
 			'local-rules/prefer-static-styles-last': 'warn',
-			'local-rules/umb-class-prefix': 'error',
-			'local-rules/no-relative-import-to-import-map-module': 'error',
 			'local-rules/enforce-umbraco-external-imports': [
 				'error',
 				{