Skip to content

Commit d12ca3c

Browse files
committed
reintroduce other splitViewElements
1 parent a1cf7eb commit d12ca3c

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

src/packages/documents/document-blueprints/workspace/document-blueprint-workspace-editor.element.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ import { UmbDocumentBlueprintWorkspaceSplitViewElement } from './document-bluepr
88

99
@customElement('umb-document-blueprint-workspace-editor')
1010
export class UmbDocumentBlueprintWorkspaceEditorElement extends UmbLitElement {
11+
//
12+
// TODO: Refactor: when having a split view/variants context token, we can rename the split view/variants component to a generic and make this component generic as well. [NL]
13+
private splitViewElement = new UmbDocumentBlueprintWorkspaceSplitViewElement();
1114

1215
#workspaceContext?: typeof UMB_DOCUMENT_BLUEPRINT_WORKSPACE_CONTEXT.TYPE;
1316

@@ -46,7 +49,7 @@ export class UmbDocumentBlueprintWorkspaceEditorElement extends UmbLitElement {
4649
routes.push({
4750
// TODO: When implementing Segments, be aware if using the unique is URL Safe... [NL]
4851
path: variantA.unique + '_&_' + variantB.unique,
49-
component: UmbDocumentBlueprintWorkspaceSplitViewElement,
52+
component: this.splitViewElement,
5053
setup: (_component, info) => {
5154
// Set split view/active info..
5255
const variantSplit = info.match.fragments.consumed.split('_&_');
@@ -63,7 +66,7 @@ export class UmbDocumentBlueprintWorkspaceEditorElement extends UmbLitElement {
6366
routes.push({
6467
// TODO: When implementing Segments, be aware if using the unique is URL Safe... [NL]
6568
path: variant.unique,
66-
component: UmbDocumentBlueprintWorkspaceSplitViewElement,
69+
component: this.splitViewElement,
6770
setup: (_component, info) => {
6871
// cause we might come from a split-view, we need to reset index 1.
6972
this.#workspaceContext?.splitView.removeActiveVariant(1);

src/packages/media/media/workspace/media-workspace-editor.element.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ import { customElement, state, css, html } from '@umbraco-cms/backoffice/externa
77
import type { UmbRoute, UmbRouterSlotInitEvent } from '@umbraco-cms/backoffice/router';
88
@customElement('umb-media-workspace-editor')
99
export class UmbMediaWorkspaceEditorElement extends UmbLitElement {
10+
//
11+
// TODO: Refactor: when having a split view/variants context token, we can rename the split view/variants component to a generic and make this component generic as well. [NL]
12+
private splitViewElement = new UmbMediaWorkspaceSplitViewElement();
1013

1114
@state()
1215
_routes?: Array<UmbRoute>;
@@ -46,7 +49,7 @@ export class UmbMediaWorkspaceEditorElement extends UmbLitElement {
4649
routes.push({
4750
// TODO: When implementing Segments, be aware if using the unique is URL Safe... [NL]
4851
path: variantA.unique + '_&_' + variantB.unique,
49-
component: UmbMediaWorkspaceSplitViewElement,
52+
component: this.splitViewElement,
5053
setup: (_component, info) => {
5154
// Set split view/active info..
5255
const variantSplit = info.match.fragments.consumed.split('_&_');
@@ -63,7 +66,7 @@ export class UmbMediaWorkspaceEditorElement extends UmbLitElement {
6366
routes.push({
6467
// TODO: When implementing Segments, be aware if using the unique is URL Safe... [NL]
6568
path: variant.unique,
66-
component: UmbMediaWorkspaceSplitViewElement,
69+
component: this.splitViewElement,
6770
setup: (_component, info) => {
6871
// cause we might come from a split-view, we need to reset index 1.
6972
this.#workspaceContext?.splitView.removeActiveVariant(1);

src/packages/members/member/workspace/member-workspace-editor.element.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ import type { UmbRoute, UmbRouterSlotInitEvent } from '@umbraco-cms/backoffice/r
88

99
@customElement('umb-member-workspace-editor')
1010
export class UmbMemberWorkspaceEditorElement extends UmbLitElement {
11+
//
12+
// TODO: Refactor: when having a split view/variants context token, we can rename the split view/variants component to a generic and make this component generic as well. [NL]
13+
private splitViewElement = new UmbMemberWorkspaceSplitViewElement();
1114

1215
#workspaceContext?: typeof UMB_MEMBER_WORKSPACE_CONTEXT.TYPE;
1316

@@ -48,7 +51,7 @@ export class UmbMemberWorkspaceEditorElement extends UmbLitElement {
4851
routes.push({
4952
// TODO: When implementing Segments, be aware if using the unique is URL Safe... [NL]
5053
path: variantA.unique + '_&_' + variantB.unique,
51-
component: UmbMemberWorkspaceSplitViewElement,
54+
component: this.splitViewElement,
5255
setup: (_component, info) => {
5356
// Set split view/active info..
5457
const variantSplit = info.match.fragments.consumed.split('_&_');
@@ -65,7 +68,7 @@ export class UmbMemberWorkspaceEditorElement extends UmbLitElement {
6568
routes.push({
6669
// TODO: When implementing Segments, be aware if using the unique is URL Safe... [NL]
6770
path: variant.unique,
68-
component: UmbMemberWorkspaceSplitViewElement,
71+
component: this.splitViewElement,
6972
setup: (_component, info) => {
7073
// cause we might come from a split-view, we need to reset index 1.
7174
this.#workspaceContext?.splitView.removeActiveVariant(1);

0 commit comments

Comments
 (0)