Skip to content

Commit f383878

Browse files
committed
Renamed "Category" to "Group" in the code
1 parent 1e4e558 commit f383878

File tree

2 files changed

+50
-42
lines changed

2 files changed

+50
-42
lines changed

src/packages/rte/tiptap/property-editors/property-editor-ui-tiptap-extensions-configuration.element.ts

Lines changed: 23 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,16 @@ type ExtensionConfig = {
1616
group: string;
1717
};
1818

19-
type ExtensionCategoryItem = {
19+
type ExtensionGroupItem = {
2020
alias: string;
2121
label: string;
2222
icon?: string;
2323
selected: boolean;
2424
};
2525

26-
type ExtensionCategory = {
27-
category: string;
28-
extensions: ExtensionCategoryItem[];
26+
type ExtensionGroup = {
27+
group: string;
28+
extensions: ExtensionGroupItem[];
2929
};
3030

3131
@customElement('umb-property-editor-ui-tiptap-extensions-configuration')
@@ -47,7 +47,7 @@ export class UmbPropertyEditorUiTiptapExtensionsConfigurationElement
4747
config?: UmbPropertyEditorConfigCollection;
4848

4949
@state()
50-
private _extensionCategories: ExtensionCategory[] = [];
50+
private _extensionCategories: ExtensionGroup[] = [];
5151

5252
@state()
5353
private _extensionConfigs: ExtensionConfig[] = [];
@@ -93,12 +93,12 @@ export class UmbPropertyEditorUiTiptapExtensionsConfigurationElement
9393
this._extensionCategories = Object.keys(grouped)
9494
.sort((a, b) => a.localeCompare(b))
9595
.map((key) => ({
96-
category: key,
96+
group: key,
9797
extensions: grouped[key],
9898
}));
9999
}
100100

101-
#onExtensionClick(item: ExtensionCategoryItem) {
101+
#onExtensionClick(item: ExtensionGroupItem) {
102102
item.selected = !item.selected;
103103

104104
if (!this.value) {
@@ -120,11 +120,11 @@ export class UmbPropertyEditorUiTiptapExtensionsConfigurationElement
120120
<div class="extensions">
121121
${repeat(
122122
this._extensionCategories,
123-
(category) => html`
124-
<div class="category">
125-
<p class="category-name">${this.localize.string(category.category)}</p>
123+
(group) => html`
124+
<div class="group">
125+
<p class="group-name">${this.localize.string(group.group)}</p>
126126
${repeat(
127-
category.extensions,
127+
group.extensions,
128128
(item) => html`
129129
<div class="extension-item">
130130
<uui-button
@@ -161,38 +161,43 @@ export class UmbPropertyEditorUiTiptapExtensionsConfigurationElement
161161
display: flex;
162162
vertical-align: unset;
163163
}
164+
164165
uui-button.selected {
165166
--uui-button-border-color: var(--uui-color-selected);
166167
--uui-button-border-width: 2px;
167168
}
169+
168170
.extensions {
169171
display: flex;
170172
flex-wrap: wrap;
171173
gap: 16px;
172174
margin-top: 16px;
173175
}
176+
174177
.extension-item {
175178
display: grid;
176179
grid-template-columns: 36px 1fr;
177180
grid-template-rows: 1fr;
178181
align-items: center;
179182
gap: 9px;
180183
}
181-
.category {
184+
185+
.group {
182186
flex: 1;
183-
background-color: var(--uui-color-surface-alt);
184-
padding: 12px;
185-
border-radius: 6px;
186187
display: flex;
187188
flex-direction: column;
188189
gap: 6px;
190+
padding: 12px;
191+
background-color: var(--uui-color-surface-alt);
189192
border: 1px solid var(--uui-color-border);
193+
border-radius: 6px;
190194
}
191-
.category-name {
195+
196+
.group-name {
192197
grid-column: 1 / -1;
193-
margin: 0;
194-
font-weight: bold;
195198
display: flex;
199+
font-weight: bold;
200+
margin: 0;
196201
}
197202
`,
198203
];

src/packages/rte/tiptap/property-editors/property-editor-ui-tiptap-toolbar-configuration.element.ts

Lines changed: 27 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ export class UmbPropertyEditorUiTiptapToolbarConfigurationElement
6565
alias: ext.alias,
6666
label: ext.meta.label,
6767
icon: ext.meta.icon,
68-
category: '',
6968
};
7069
});
7170

@@ -175,14 +174,16 @@ export class UmbPropertyEditorUiTiptapToolbarConfigurationElement
175174
#renderItem(alias: string, rowIndex: number, groupIndex: number, itemIndex: number) {
176175
const extension = this._extensions.find((ext) => ext.alias === alias);
177176
if (!extension) return nothing;
178-
return html`<div
179-
title=${extension.label}
180-
class="item"
181-
draggable="true"
182-
@dragend=${this.#onDragEnd}
183-
@dragstart=${(e: DragEvent) => this.#onDragStart(e, alias, [rowIndex, groupIndex, itemIndex])}>
184-
<umb-icon name=${extension.icon ?? ''}></umb-icon>
185-
</div>`;
177+
return html`
178+
<div
179+
title=${extension.label}
180+
class="item"
181+
draggable="true"
182+
@dragend=${this.#onDragEnd}
183+
@dragstart=${(e: DragEvent) => this.#onDragStart(e, alias, [rowIndex, groupIndex, itemIndex])}>
184+
<umb-icon name=${extension.icon ?? ''}></umb-icon>
185+
</div>
186+
`;
186187
}
187188

188189
#renderGroup(group: string[], rowIndex: number, groupIndex: number) {
@@ -232,21 +233,23 @@ export class UmbPropertyEditorUiTiptapToolbarConfigurationElement
232233

233234
#renderExtensions() {
234235
// TODO: Can we avoid using a flat here? or is it okay for performance?
235-
return html`<div class="extensions" dropzone="move" @drop=${this.#onDrop} @dragover=${this.#onDragOver}>
236-
${repeat(
237-
this._extensions.filter((ext) => !this.#value.flat(2).includes(ext.alias)),
238-
(extension) => html`
239-
<div
240-
title=${extension.label}
241-
class="item"
242-
draggable="true"
243-
@dragend=${this.#onDragEnd}
244-
@dragstart=${(e: DragEvent) => this.#onDragStart(e, extension.alias)}>
245-
<umb-icon name=${extension.icon ?? ''}></umb-icon>
246-
</div>
247-
`,
248-
)}
249-
</div>`;
236+
return html`
237+
<div class="extensions" dropzone="move" @drop=${this.#onDrop} @dragover=${this.#onDragOver}>
238+
${repeat(
239+
this._extensions.filter((ext) => !this.#value.flat(2).includes(ext.alias)),
240+
(extension) => html`
241+
<div
242+
title=${extension.label}
243+
class="item"
244+
draggable="true"
245+
@dragend=${this.#onDragEnd}
246+
@dragstart=${(e: DragEvent) => this.#onDragStart(e, extension.alias)}>
247+
<umb-icon name=${extension.icon ?? ''}></umb-icon>
248+
</div>
249+
`,
250+
)}
251+
</div>
252+
`;
250253
}
251254

252255
static override styles = [

0 commit comments

Comments
 (0)